fix https://github.com/gitcoinco/web/issues/8466 #8731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelostone-mc
requested review from
chibie,
frankchen07,
gdixon,
octavioamu and
PixelantDesign
as code owners
gdixon
suggested changes
Mar 31, 2021
| </h5> | ||
| <a :href="`/profile/${ user.handle }`" v-bind:data-usercard="[[ user.handle ]]" class="text-center d-block"> | ||
| @[[ user.handle ]] | ||
| <div v-for="user in users" class="card border-bottom-0 border-left-0 border-right-0 border-top pt-4" :key="user.id"> |
There was a problem hiding this comment.
Rather than using card and dropping the borders, could we use border-top-1 border-grey instead? I feel like the rounded corners make it look odd?
There was a problem hiding this comment.
Oh i'm not sure why it was built like that but updating it
iRhonin
pushed a commit
to iRhonin/web
that referenced
this pull request
Apr 23, 2021
* fix gitcoinco#8466 * address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #8466