Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update address #8745

Merged
merged 2 commits into from
Apr 7, 2021
Merged

update address #8745

merged 2 commits into from
Apr 7, 2021

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Apr 6, 2021 •
edited

Description

Address updated to 0x88c62f1695DD073B43dB16Df1559Fda841de38c6

  • Bounty Creation - Fee
  • Bounty Creation - Feature a Bounty
  • Bounty Update - Fee
  • Bounty Update - Feature a Bounty
  • Joe Dominance Stats

Address updated to 0xAD278911Ad07534F921eD7D757b6c0e6730FCB16

  • Avatar
  • Tips (Bulk)
  • Kudos KUDOS_REVENUE_ACCOUNT_ADDRESS

Address updated to 0xd08Fe0c97c80491C6ee696Ee8151bc6E57d1Bf1d

  • Gitcoin Grant Address (in live- admin)
  • Gitcoin Donation Address in Grant Checkout

These will not be updated

  • FEE_ADDRESS + FEE_ADDRESS_PRIVATE_KEY (used in fee swapper)
  • MINICLR_ADDRESS + MINICLR_PRIVATE_KEY
  • AVATAR_ADDRESS + AVATAR_PRIVATE_KEY ( used in create_text_input -> but not invoked anywhere)
  • GRANTS_PAYOUT_ADDRESS + GRANTS_PAYOUT_PRIVATE_KEY
  • TIP_PAYOUT_ADDRESS + TIP_PAYOUT_PRIVATE_KEY (used in bulk tips)
Refers/Fixes

#8673

@octavioamu octavioamu requested a review from owocki April 6, 2021 13:35
@octavioamu
Copy link
Contributor

Added @owocki to help us review this as I had the same questions as you. Can you help us Owocki?

@thelostone-mc
Copy link
Member Author

@octavioamu synced up with kevin
Anything with private key will not be updated! We'll just update the read only keys

@thelostone-mc thelostone-mc changed the base branch from stable to master April 7, 2021 09:11
@thelostone-mc thelostone-mc merged commit bb6870b into master Apr 7, 2021
@gdixon gdixon mentioned this pull request Apr 8, 2021
Merged
iRhonin pushed a commit to iRhonin/web that referenced this pull request Apr 23, 2021
@thelostone-mc @iRhonin
update address (gitcoinco#8745)
c261888 
* update address

* feedback after syncing with kevin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octavioamu octavioamu octavioamu approved these changes

@chibie chibie Awaiting requested review from chibie

@frankchen07 frankchen07 Awaiting requested review from frankchen07

@gdixon gdixon Awaiting requested review from gdixon

@PixelantDesign PixelantDesign Awaiting requested review from PixelantDesign

@owocki owocki Awaiting requested review from owocki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thelostone-mc @octavioamu