Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sia crosschain | bounties/hackathons #8899

Merged
merged 8 commits into from
Jun 7, 2021
Merged

Conversation

chibie
Copy link
Contributor

@chibie chibie commented May 13, 2021

Description

Description

Bounties Integration

Frontend

  • Add chain to bounty creation + hack form form (staff flag)
  • Funder should be able to create bounty with sia
  • User should be able to start / stop / submit work with sia
  • Funder should be able to payout + change funder address

Backend

  • Add in chain sync logic
  • Fix fulfil flow for bounty
  • Testing
Refers/Fixes
Testing

- add logo
- create bounty flow
- add sia extension
- allow change of address
@chibie chibie marked this pull request as ready for review May 14, 2021 01:16
@thelostone-mc
Copy link
Member

  • Why are we allowing funder to update the address at payout
  • Is there no QR flow/ Did we get an agreement that they are good with the QR payout

Let's make sure the Sia team is good with the copy-paste (this is like the last resort if nothing else can be done)

@chibie
Copy link
Contributor Author

chibie commented May 14, 2021

@thelostone-mc we can confer with the team.

but I used their desktop wallet, there's no QR code there, just address copy.

and the mobile app that should have that feature is an unofficial one.

@thelostone-mc
Copy link
Member

we can confer with the team.

Let's get that clarified before we get this in

@chibie
Copy link
Contributor Author

chibie commented May 17, 2021

@thelostone-mc nemo from the team is good with it. i shared the demo vids on the discord channel over the weekend

@chibie chibie requested a review from zlsgh as a code owner June 1, 2021 21:12
@thelostone-mc thelostone-mc added this to Engineering-Review in PR Review Board Jun 2, 2021
@chibie chibie added this to In progress in Gitcoin Product Group (GPG) via automation Jun 2, 2021
@chibie chibie self-assigned this Jun 2, 2021
@thelostone-mc thelostone-mc merged commit ee6260c into master Jun 7, 2021
PR Review Board automation moved this from Engineering-Review to Done Jun 7, 2021
Gitcoin Product Group (GPG) automation moved this from In progress to Done Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants