fix: POAP - Ensures that all tokens are considered and not just the token with the lowest ID #8994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: owocki <ksowocki@gmail.com>
gdixon
requested review from
chibie,
frankchen07,
octavioamu,
PixelantDesign,
thelostone-mc and
zlsgh
as code owners
thelostone-mc
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR corrects the logic for POAP verifications.
The old logic made the assumption that the token with the lowest ID was transferred earliest, according to this report - the earliest transfer might not always have the lowest ID. This could be because the tokens were minted earlier and then transferred to the user, or it could be down to the order that the tokens were transferred from xDai to mainnet. Either way, this PR alters the logic so that:
Refers/Fixes
fixes: #8979
Testing
Tested locally against the address provided in slack