feat: algorand grants integration #9168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelostone-mc
force-pushed
the
algo
branch
2 times, most recently
from
4dc589d
to
31e93d3
Compare
thelostone-mc
requested review from
chibie,
frankchen07,
gdixon,
octavioamu,
PixelantDesign and
zlsgh
as code owners
thelostone-mc
changed the title
zlsgh
reviewed
Jun 28, 2021
zlsgh
reviewed
Jun 28, 2021
|
|
||
| if ( | ||
| not eth_payout_address and not zcash_payout_address and | ||
| not celo_payout_address and not zil_payout_address and | ||
| not polkadot_payout_address and not kusama_payout_address and | ||
| not harmony_payout_address and not binance_payout_address and | ||
| not rsk_payout_address | ||
| not rsk_payout_address and not algorand_payout_address |
There was a problem hiding this comment.
It looks like we have a lot of places here where we have to check for every chain in these conditionals. Rather than repeating these over and over, could we make a set and then check the set? For example with these payout addresses, rather than doing this long list of nots would it be cleaner to add these to a set and then check if the set is empty?
all_payout_address_types = {eth_payout_address, zcash_payout_address, celo_payout_address, zil_payout_address, polkadot_payout_address, kusama_payout_address, harmony_payout_address, binance_payout_address, rsk_payout_address, algorand_payout_address}
if not all_payout_address_types:
response['message'] = 'error: payout_address is a mandatory parameter'
There was a problem hiding this comment.
Does that work @zacheryschiller ?
I'd say we'd do it in a followup PR
There was a problem hiding this comment.
as synced up offline -> will do this in a follow up PR
There was a problem hiding this comment.
My bad. Should be if not any(all_payout_address_types):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims at integrating algorand into grants.
It uses the algosigner to contribute to grants
Steps tested
Grant Creation
https://share.vidyard.com/watch/4z4rhUbCNw3jhAttzy47LK?
Grant Payout
https://share.vidyard.com/watch/oqoMReMN4f6M9UTQuCNaGG?
Backend Sync
Fixes GITC-65