GITC-112: tezos crosschain | bounties/hackathons #9182
Conversation
- switch to mainnet - count confirmations
chibie
requested review from
frankchen07,
gdixon,
octavioamu,
PixelantDesign,
thelostone-mc and
zlsgh
as code owners
thelostone-mc
moved this from Engineering-Review
to Waiting on contributor
in PR Review Board
chibie
changed the title
app/assets/v2/js/navbar.js
Outdated
| @@ -32,10 +32,10 @@ const makeMenu = (navbarEl) => { | |||
| }; | |||
|
|
|||
| // pull computedRootStyles from shared.js or compute here | |||
| const computedRootStyles = (window.hasOwnProperty('computedRootStyles') ? window.computedRootStyles : getComputedStyle(document.documentElement)); | |||
| const computedRootStyles = (Object.prototype.hasOwnProperty.call(window, 'computedRootStyles') ? window.computedRootStyles : getComputedStyle(document.documentElement)); | |||
There was a problem hiding this comment.
is this needed? I think this will break the nav as I remember @gdixon doing some changes to window instead because the bundle.
Anyway not sure this should be part of this PR.
There was a problem hiding this comment.
@octavioamu i was unable to push cause of eslint pre-commit hook... it kept throwing an error and that was the fix
There was a problem hiding this comment.
ok now is fixed on stable and master, just fixed the conflicts on this one also.
| payout_type: 'tezos_ext', | ||
| tenant: 'TEZOS', | ||
| amount: amount, | ||
| token_name: token_name, | ||
| funder_address: from_address, | ||
| payout_tx_id: txn |
There was a problem hiding this comment.
there are some variables not sure where are defined as are not function parameters. As I understand there is a mistake and amount need to be txn.amount for example, but not 100% suer as don't know what wallet.sendO... returns
There was a problem hiding this comment.
@octavioamu amount and token_name vars are defined in L3 & L4 respectively
| if (!isNervosValid && !vm.form.funderAddress.toLowerCase().startsWith('0x')) { | ||
| isValid = false; |
There was a problem hiding this comment.
this still confused me, didn't test but I believe will be always false as first is checking ckb at the first part of the string
There was a problem hiding this comment.
addressed here #9182 (comment)
| fulfillment.payout_status = 'done' | ||
| fulfillment.accepted_on = timezone.now() | ||
| fulfillment.accepted = True | ||
| record_payout_activity(fulfillment) |
There was a problem hiding this comment.
consider: celery task for this
There was a problem hiding this comment.
hmm maybe when we refactor em all ! right now this barely takes time
Description
Integrate Tezos chain into Gitcoin platform so that users would be allowed to use XTZ for bounties and hackathons
Bounties Integration
Frontend
Backend
Refers/Fixes
closes #8995
Testing
create bounty, start/submit work - https://www.loom.com/share/9007ec9dca534e4fbd42376238241c62
payout bounty / verify transaction - https://www.loom.com/share/ebd24255e88e4edbab906d44d883a864