GITC-194: Replaces ./js/libs/* with NPM libs #9276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdixon
changed the title
gdixon
requested review from
chibie,
frankchen07,
octavioamu,
PixelantDesign,
thelostone-mc and
zlsgh
as code owners
zlsgh
approved these changes
Jul 16, 2021
chibie
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces libs inside
./assets/v2/js/libs/with bundle tags which will load the same script from node_modules (listing all requirements with their current versions in package.json)Refers/Fixes
Fixes: GITC-194
Testing
Tested everything on local