Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GITC-209: sentry fixes #9296

Merged
merged 5 commits into from
Jul 15, 2021
Merged

GITC-209: sentry fixes #9296

merged 5 commits into from
Jul 15, 2021

Conversation

thelostone-mc
Copy link
Member

Description

This PR fixes the following issues on sentry

  • sentry: can only concatenate str (not NoneType) to str
  • sentry: NoneType' object has no attribute 'decode
  • sentry: (invalid_client) Unauthorized
  • sentry: Given address is not a valid Ethereum address
  • sentry: value too long for type character varying(500)
Refers/Fixes
Testing

Locally Tested

gdixon
gdixon approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@gdixon gdixon left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

RE: sentry: value too long for type character varying(500)

For a separate ticket, lets look to rename images uploaded against Grants before pushing to s3 so that we don't have to worry about this limit in the future 👍

zlsgh
zlsgh approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@zlsgh zlsgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

gcc20
gcc20 approved these changes Jul 15, 2021
View reviewed changes
Copy link

@gcc20 gcc20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

chibie
chibie approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@chibie chibie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@thelostone-mc thelostone-mc merged commit c9e37a2 into gitcoinco:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdixon gdixon gdixon approved these changes

@chibie chibie chibie approved these changes

@gcc20 gcc20 gcc20 approved these changes

@zlsgh zlsgh zlsgh approved these changes

@frankchen07 frankchen07 Awaiting requested review from frankchen07

@octavioamu octavioamu Awaiting requested review from octavioamu

@PixelantDesign PixelantDesign Awaiting requested review from PixelantDesign

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thelostone-mc @gdixon @chibie @gcc20 @zlsgh