Fix invalid usages of ArgumentNullException

gitextensions · Mar 13, 2018 · f2b6df1 · f2b6df1
1 parent 2eeee62
commit f2b6df1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/GitExtUtils/Linq/LinqExtensions.cs b/GitExtUtils/Linq/LinqExtensions.cs
@@ -44,9 +44,10 @@ public static Dictionary<TKey, List<TSource>> ToDictionaryOfList<TSource, TKey>(
             foreach (TSource sourceElement in source)
             {
                 TKey key = keySelector(sourceElement);
+
                 if (key == null)
                 {
-                    var ex = new ArgumentNullException("KeySelector produced a key that is null. See exception data for source.");
+                    var ex = new Exception("KeySelector produced a key that is null. See exception data for source.");
                     ex.Data.Add("source", sourceElement);
                     throw ex;
                 }
@@ -75,9 +76,10 @@ public static HashSet<TKey> ToHashSet<TSource, TKey>(this IEnumerable<TSource> s
             foreach (TSource sourceElement in source)
             {
                 TKey key = keySelector(sourceElement);
+
                 if (key == null)
                 {
-                    var ex = new ArgumentNullException("KeySelector produced a key that is null. See exception data for source.");
+                    var ex = new Exception("KeySelector produced a key that is null. See exception data for source.");
                     ex.Data.Add("source", sourceElement);
                     throw ex;
                 }

diff --git a/Plugins/Gerrit/GerritPlugin.cs b/Plugins/Gerrit/GerritPlugin.cs
@@ -98,7 +98,7 @@ private bool HaveValidCommitMsgHook([NotNull] IGitModule gitModule, bool force)
         {
             if (gitModule == null)
             {
-                throw new ArgumentNullException("gitDirectory");
+                throw new ArgumentNullException(nameof(gitModule));
             }
 
             string path = Path.Combine(gitModule.ResolveGitInternalPath("hooks"), "commit-msg");