Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Enter commit message' does not disappear when you start typing your message #3491

Closed
mnaoumov opened this issue Jan 13, 2017 · 5 comments
Closed

Comments

@mnaoumov
Copy link
Contributor

commit

@crypto-rsa
Copy link
Contributor

crypto-rsa commented Mar 16, 2017

I can confirm this.
Steps to reproduce:

  1. Make some changes in the repository
  2. Go to the Commit dialog and make sure the Close dialog after each commit option is off
  3. Stage some, but not all changes
  4. Enter a commit message and press Ctrl+Enter
  5. After the commit is performed, dismiss the Process window

The commit message window is now focused, the cursor is at the beginning but the "watermark" text is again displayed. If you now start typing, the text will be drawn in gray and it won't be registered as the true message text (ie. when you now try to commit the rest of the changes, a message box will appear saying Please enter commit message).

crypto-rsa added a commit to crypto-rsa/gitextensions that referenced this issue Mar 17, 2017
…xtensions#3491)

The Enter/Leave handlers are not called when the focus returns to the text box
after another focused window is closed.
crypto-rsa added a commit to crypto-rsa/gitextensions that referenced this issue Mar 17, 2017
…xtensions#3491)

The Enter/Leave handlers are not called when the focus returns to the text box
after another focused window is closed.
@jbialobr jbialobr added this to the 2.49.2 milestone Mar 17, 2017
jbialobr added a commit that referenced this issue Mar 17, 2017
Toggle the watermark in GotFocus/LostFocus event handlers (fixes #3491)
@dhilgarth
Copy link

I am using version 2.51 and I am seeing this. Is this a regression?

@DmitryZhelnin
Copy link
Contributor

I'm experiencing this issue too. Version 2.51.01. Sometimes the watermark text is displayed as regular text. Sometimes when I start to type my commit message it has watermark style and appends to existing watermark text.

@RussKie
Copy link
Member

RussKie commented May 11, 2018

OS? .NET version? under what circumstances?

@dhilgarth
Copy link

OS: Windows 10 Version 1803 Build 17134.48
GitExtensions: 2.51.01
.NET Framework versions: 4.5.1, 4.6.1, 4.6.2, 4.7, 4.7.1

Circumstances: Unclear. For some repositories it seems to happen always, other repositories don't experience this. It might be related to the file .git\description. The repository that experienced this was unnamed. Once I edited that file, the problem went away. However, editing the file so that the repository was unnamed again, didn't make the problem re-appear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants