Feature request: assign F2 key to "Rename branch"

[jrfnl]

I often rename branches to keep track of work in progress / PR / waiting for.... etc. and I noticed myself intuitively using the F2 key to do this - which doesn't work -.
F2 seems to make sense as it is used in a lot of other programs for "edit name" type functionality and I was wondering whether it could be added or alternatively, whether the "Rename branch" command could be added to the list of commands you can assign a hotkey to.

[marazt]

It is a good idea. But there is one problem. If you have multiple branches on the same line, the shortcut does not know which branch you want to rename. So for this situation there must be some option how to specify a branch to be renamed (probably some dialog).

[jrfnl]

Just thinking out loud: what about automatically assuming the branch to rename is the one selected on the screen if the selected commit is the head of a branch (is that the right term?).

If a commit is selected without a branch head or if no commit is selected, show a dialogue ?

[mdonatas]

@jrfnl I think the point of previous comment was regarding situation when there are multiple branches pointing at the same commit. Then you'd need a dialog to make a selection.

[jrfnl]

@mdonatas Sorry, I read it too quickly. Still a (minimalistic) dialogue for multiple branches pointing to the same commit and for a selected commit not being the head of a branch, sounds good.

[vbjay]

Think. If the head is pointing to master and upstream/master and featurex and featurey branch which branch do you want to rename? Some logic like not master and not remote branches but do we rename featurex or featurey?

…

On Wed, Jan 25, 2017, 9:51 AM Juliette ***@***.***> wrote: @mdonatas <https://github.com/mdonatas> Sorry, I read it too quickly. Still a (minimalistic) dialogue for multiple branches pointing to the same commit and for a selected commit not being the head of a branch, sounds good. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3503 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADdhsTLoUm1UCAsFu3mmTqFNbuWc7s3Rks5rV2FygaJpZM4Lqjv_> .

[marazt]

@vbjay That is exactly what I pointed in my previous post.

[vbjay]

I know. He didn't seem to get it

…

On Wed, Jan 25, 2017, 10:22 AM Marek Polak ***@***.***> wrote: @vbjay <https://github.com/vbjay> That is exactly what I pointed in my previous post. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3503 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADdhsYYZPRIdNcm4fD4setDGc32o-Mp5ks5rV2i9gaJpZM4Lqjv_> .

[vbjay]

It doesn't matter if it is head or not.

…

On Wed, Jan 25, 2017, 11:04 AM Jay Asbury ***@***.***> wrote: I know. He didn't seem to get it On Wed, Jan 25, 2017, 10:22 AM Marek Polak ***@***.***> wrote: @vbjay <https://github.com/vbjay> That is exactly what I pointed in my previous post. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3503 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADdhsYYZPRIdNcm4fD4setDGc32o-Mp5ks5rV2i9gaJpZM4Lqjv_> .

[jrfnl]

@vbjay No need to get all wound up over some terminology confusion. I already pointed out myself in my second comment that I wasn't sure if I was using the right terms to express what I meant.

All the same I did get the point. You clearly didn't.

I know. He didn't seem to get it

Oh dear... misogyny or just professional deformation ?

[jrfnl]

Thank you @RussKie for adding this in!