Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-credential-winstore.exe missing #3732

Closed
wsw70 opened this issue May 29, 2017 · 10 comments · Fixed by #5132
Closed

git-credential-winstore.exe missing #3732

wsw70 opened this issue May 29, 2017 · 10 comments · Fixed by #5132

Comments

@wsw70
Copy link

wsw70 commented May 29, 2017

Do you want to request a feature or report a bug?

Report a bug

What is the current behavior?

When pushing I get an error message about missing git-credential-winstore.exe:

"C:\Program Files\Git\bin\git.exe" push -u --recurse-submodules=check --progress "origin" refs/heads/master:refs/heads/master
Counting objects: 4, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 423 bytes | 0 bytes/s, done.
Total 4 (delta 3), reused 0 (delta 0)
"C:\Program Files (x86)\GitExtensions\GitCredentialWinStore\git-credential-winstore.exe" erase: C:\Program Files (x86)\GitExtensions\GitCredentialWinStore\git-credential-winstore.exe: No such file or directory
featal: The remote end hung up unexpectedly
fatal: The remote end hung up unexpectedly
rror: RPC failed; HTTP 401 curl 22 The requested URL returned error: 401
Everything up-to-date

The Windows Credential pop-up does appears, enabling me to input my credentials, then I get the error above.

Which versions of GIT and which versions of Windows are affected by this issue? Did this work in previous versions of our tool?

This bug has been reported previously (for instance ferventcoder/chocolatey-packages#31) but still happens with fresh installs.

  • My Git Extensions install is 2.49.03, "Complete" install package with all features enabled.
  • I do not have any entries in my git config file (.git/config) which would point to the path referenced in the error log above.
@mortb
Copy link

mortb commented May 30, 2017

I use gitextensions 2.49.03
I have a reference to git-credential-winstore.exe in the .gitconfig file which is placed in the "my documents" (%homedrive%homepath%) folder. I have no problems pushing, but we do not use http, we use ssh or git protocol

@RussKie
Copy link
Member

RussKie commented Jun 2, 2017

does this relate to #3511?

afaik, git-credential-winstore.exe is needed for http

@increddibelly
Copy link

still here in 2.50.02. and I upgrade so few times that I forget the fix every time. C'mon guys...

@RussKie
Copy link
Member

RussKie commented Nov 20, 2017

What do you expect us to do?

@increddibelly
Copy link

when you search for 'git credential winstore' it seems clear that gitextensions assumes defaults that aren't valid for many users. these issues date back to 2012 at least.
out of the top of my head, you could assume a safer default / verify the assumed value works BEFORE using it / add a check in the checklist?

@increddibelly
Copy link

increddibelly commented Nov 23, 2017

actually, I've found it. again.
C:\users.gitconfig contains the following snippet:
helper = !\"C:\\Program Files (x86)\\GitExtensions\\GitCredentialWinStore\\git-credential-winstore.exe\"
but instead, this should be
helper = \"C:\\Program Files (x86)\\GitExtensions\\GitCredentialWinStore\\git-credential-winstore.exe\"

imho gitextensions should not write the ! to the config.

@vbjay
Copy link
Contributor

vbjay commented Nov 23, 2017 via email

@RussKie
Copy link
Member

RussKie commented Nov 23, 2017

I think in this context, leading bang means "treat it as a shell command (executable)".... though I may be wrong

@RussKie
Copy link
Member

RussKie commented Nov 23, 2017

I've searched the codebase and I can't find anything installs git-credential-winstore.exe or configures it.
I can only speculate that it is done by git for windows installation.

In #3511 there are suggested workarounds to replace it with wincred or manager.

@pmme
Copy link
Contributor

pmme commented Nov 28, 2017

The problem is not what GitExtensions 2.49 and later are doing, instead it's that earlier versions of GitExtensions created a setting (at a time when it was appropriate) and that setting now remains. In #3511 I wrote the command to remove the setting or change it to an alternative.

I have a suggestion: #4179

@RussKie RussKie added this to the 3.00 milestone Jul 3, 2018
RussKie added a commit to RussKie/gitextensions that referenced this issue Jul 4, 2018
Check whether the user has an outdated setting pointing to
git-credential-winstore.exe and, if so, notify the user and point to our
GitHub wiki with more information:
https://github.com/gitextensions/gitextensions/wiki/How-To:-fix-GitCredentialWinStore-missing

Fixes gitextensions#3511
Fixes gitextensions#3732
Fixes gitextensions#4179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants