Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Remove or change old credential.helper setting #4179

Closed
pmme opened this issue Nov 28, 2017 · 1 comment · Fixed by #5132
Closed

Feature: Remove or change old credential.helper setting #4179

pmme opened this issue Nov 28, 2017 · 1 comment · Fixed by #5132

Comments

@pmme
Copy link
Contributor

pmme commented Nov 28, 2017

Feature request.

This feature would have GitExtensions offer to fix or undo an old setting that confuses many users and causes issues to be logged on this repo.

Old versions of GitExtensions installed their own copy of GitCredentialWinstore in a sub-folder of the GitExtensions installation and created the global setting credential.helper to use that credential helper.

GitExtensions 2.49 and later do not install a credential helper and therefore do not set the global setting credential.helper.

The problem then is that the old setting refers to a program that no longer exists and we get #3511 and #3732.

I suggest that GitExtensions could detect when credential.helper is set to its previous own copy of GitCredentialWinstore:
!\"C:\\Program Files (x86)\\GitExtensions\\GitCredentialWinStore\\git-credential-winstore.exe\".

The GitExtensions installer could either

  • Offer to remove that setting. Removing that setting would return the user to entering a username and password when pushing.
  • Change it to use git's credential helper, wincred.

This is automating the workaround that I wrote in #3511.

GitExtensions version: 2.49 to current, 2.50.02
GIT version: 2.13.3.windows.1
OS version: Windows 7

@pmme pmme changed the title Remove or change old credential.helper setting Feature: Remove or change old credential.helper setting Nov 28, 2017
@GreenReaper
Copy link

This was confusing - I upgraded Git Extensions and suddenly pushing didn't work! Ended up reinstalling everything git and credential related, which fixed it, but it would have been nice if that hadn't happened.

@RussKie RussKie added this to the 3.00 milestone Jul 3, 2018
RussKie added a commit to RussKie/gitextensions that referenced this issue Jul 4, 2018
Check whether the user has an outdated setting pointing to
git-credential-winstore.exe and, if so, notify the user and point to our
GitHub wiki with more information:
https://github.com/gitextensions/gitextensions/wiki/How-To:-fix-GitCredentialWinStore-missing

Fixes gitextensions#3511
Fixes gitextensions#3732
Fixes gitextensions#4179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants