Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff tab: file list resize bug #5437

Closed
RussKie opened this issue Sep 16, 2018 · 0 comments · Fixed by #5542
Closed

Diff tab: file list resize bug #5437

RussKie opened this issue Sep 16, 2018 · 0 comments · Fixed by #5542
Labels
area: user experience type: bug 🐛
Milestone
3.00-RC1

Comments

@RussKie
Copy link
Member

RussKie commented Sep 16, 2018 •
edited
Loading

Do you want to request a feature or report a bug?
bug

What is the current behavior?
The listview (or the entries in it) moves to the right
diff-tab-bug-1

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
Courtesy of @NikolayXHD:

  1. Set truncate long filename setting to None
  2. resize file status panel to the size when horizontal scroll appears
  3. move scroll to the right (not necessarily rightmost) position
  4. [optional] double-click group header twice to collapse and re-expand the group
  5. resize the panel in 1 large movement, larger than the missing width created on step 2.

Note: step 4 is optional. collapse / expand does not have to do with the issues at all.
The problem is caused by resizing the panel while the scroll is not in leftmost position

What is the expected behavior?
Correct layout after resize

Environment you encounter the issue:
Current master @ 7c4e8c5

Did this work in previous version of GitExtensions (which)?
No, 2.51 exhibits the same behavior
@RussKie RussKie added this to the 3.00 milestone Sep 16, 2018
RussKie pushed a commit to RussKie/gitextensions that referenced this issue Sep 19, 2018
Remove SizeChanged handler
ad3f8b4 
The current implementation of the `SizeChanged` handler causes a bad
distortion to the UI and renders the listview unusable.

The handler is removed and the column is resized at the time of bindings
items to the list.
This adds a small artifact that if the list was resized after items have
been bound, the column may no longer be of the full width of the list.

Fixes gitextensions#5437
Fixes gitextensions#5438
@RussKie RussKie mentioned this issue Sep 19, 2018
Merged
gerhardol pushed a commit to gerhardol/gitextensions that referenced this issue Sep 23, 2018
@gerhardol
Remove SizeChanged handler
ec55b0f 
The current implementation of the `SizeChanged` handler causes a bad
distortion to the UI and renders the listview unusable.

The handler is removed and the column is resized at the time of bindings
items to the list.
This adds a small artifact that if the list was resized after items have
been bound, the column may no longer be of the full width of the list.

Fixes gitextensions#5437
Fixes gitextensions#5438
gerhardol pushed a commit to gerhardol/gitextensions that referenced this issue Sep 24, 2018
@gerhardol
Remove SizeChanged handler
d58b7ff 
The current implementation of the `SizeChanged` handler causes a bad
distortion to the UI and renders the listview unusable.

The handler is removed and the column is resized at the time of bindings
items to the list.
This adds a small artifact that if the list was resized after items have
been bound, the column may no longer be of the full width of the list.

Fixes gitextensions#5437
Fixes gitextensions#5438
@RussKie RussKie modified the milestones: 3.00, 3.00-beta2 Sep 26, 2018
@NikolayXHD NikolayXHD mentioned this issue Oct 9, 2018
Merged
RussKie pushed a commit that referenced this issue Oct 13, 2018
@NikolayXHD @RussKie
File status list tweaks (#5542)
0655fc2 
#5437 
* Auto resilze FileStatusList column
* more accurate Ctrl+A handling in FileStatusList
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: user experience type: bug 🐛
Projects
None yet
Milestone
3.00-RC1
Development

Successfully merging a pull request may close this issue.

File status list tweaks
1 participant
@RussKie