Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff tab: can't select file in the file list #5438

Closed
RussKie opened this issue Sep 16, 2018 · 2 comments
Closed

Diff tab: can't select file in the file list #5438

RussKie opened this issue Sep 16, 2018 · 2 comments

Comments

@RussKie
Copy link
Member

RussKie commented Sep 16, 2018

Do you want to request a feature or report a bug?
bug

What is the current behavior?
Unable to select files after resize events. The entries can't be clicked on, unless the listview is resized in a specific way and scrolled to the left
diff-tab-bug-2

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
Courtesy of @NikolayXHD:

  1. Set truncate long filename setting to None
  2. resize file status panel to the size when horizontal scroll appears
  3. move scroll to the right (not necessarily rightmost) position
  4. [optional] double-click group header twice to collapse and re-expand the group
  5. resize the panel in 1 large movement, larger than the missing width created on step 2.

Note: step 4 is optional. collapse / expand does not have to do with the issues at all.
The problem is caused by resizing the panel while the scroll is not in leftmost position

What is the expected behavior?
Entries can be selected

Environment you encounter the issue:
Current master @ 7c4e8c5

Did this work in previous version of GitExtensions (which)?
No, 2.51 exhibits the same behavior

@RussKie RussKie added this to the 3.00 milestone Sep 16, 2018
RussKie pushed a commit to RussKie/gitextensions that referenced this issue Sep 19, 2018
The current implementation of the `SizeChanged` handler causes a bad
distortion to the UI and renders the listview unusable.

The handler is removed and the column is resized at the time of bindings
items to the list.
This adds a small artifact that if the list was resized after items have
been bound, the column may no longer be of the full width of the list.

Fixes gitextensions#5437
Fixes gitextensions#5438
gerhardol pushed a commit to gerhardol/gitextensions that referenced this issue Sep 23, 2018
The current implementation of the `SizeChanged` handler causes a bad
distortion to the UI and renders the listview unusable.

The handler is removed and the column is resized at the time of bindings
items to the list.
This adds a small artifact that if the list was resized after items have
been bound, the column may no longer be of the full width of the list.

Fixes gitextensions#5437
Fixes gitextensions#5438
gerhardol pushed a commit to gerhardol/gitextensions that referenced this issue Sep 24, 2018
The current implementation of the `SizeChanged` handler causes a bad
distortion to the UI and renders the listview unusable.

The handler is removed and the column is resized at the time of bindings
items to the list.
This adds a small artifact that if the list was resized after items have
been bound, the column may no longer be of the full width of the list.

Fixes gitextensions#5437
Fixes gitextensions#5438
@RussKie RussKie modified the milestones: 3.00, 3.00-beta2 Sep 26, 2018
@slate-dk
Copy link

Just upgraded to 3.00.00.4433 and had this happen to me almost immediately.
Did not see it with the 2.5.** I used previously

Reopened client and problem was gone; not able to recreate immediately.

GitExtensions version: Version 3.00.00 4433
OS version: Windows 7
.NET version: 4.6.2
Machine specs:
Intel Core i5-6820HQ @ 2.70 GHz
32GB RAM

@gerhardol
Copy link
Member

Please open a new issue, this specific issue has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants