Portable build should set IsPortable in config

[vbjay]

Do you want to request a feature or report a bug?
bug
What is the current behavior?

The portable build doesn't alter GitExtensions.exe.config

<GitCommands.Properties.Settings>
      <!--Set this setting to True to store settings with the application, False to  store settings in user's application data path.-->
      <setting name="IsPortable" serializeAs="String">
        <value>False</value>
      </setting>
    </GitCommands.Properties.Settings>

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.

What is the expected behavior?

This value should be True on a portable build.
Environment you encounter the issue:

• Git Extensions 3.00.rc2
• ef05b7c
• Git 2.19.1.windows.1
• Microsoft Windows NT 10.0.17763.0
• .NET Framework 4.7.3190.0
• DPI X:100.00% Y:100.00%

Did this work in previous version of GitExtensions (which)?

[vbjay]

I have a solution. Just trying to get the MakePortable.cmd run the powershell

$doc= [xml](Get-Content .\GitExtensions\GitExtensions.exe.config)
$port=$doc.configuration.applicationSettings.'GitCommands.Properties.Settings'.setting|? {$_.name -eq 'IsPortable'}
$port.value="True"
$pth = Resolve-Path .\GitExtensions
$doc.Save([System.IO.Path]::Combine($pth,"GitExtensions.exe.config"))

[RussKie]

I'd tweak the Prepare-Release.ps1 script to inject the right value before packaging the portable archive

…

On Tue, 13 Nov 2018 at 11:27, Jay Asbury ***@***.***> wrote: *Do you want to request a feature or report a bug?* *What is the current behavior?* The portable build doesn't alter GitExtensions.exe.config <GitCommands.Properties.Settings> <!--Set this setting to True to store settings with the application, False to store settings in user's application data path.--> <setting name="IsPortable" serializeAs="String"> <value>False</value> </setting> </GitCommands.Properties.Settings> *If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.* *What is the expected behavior?* This value should be True on a portable build. *Environment you encounter the issue:* - Git Extensions 3.00.rc2 - ef05b7c <ef05b7c> - Git 2.19.1.windows.1 - Microsoft Windows NT 10.0.17763.0 - .NET Framework 4.7.3190.0 - DPI X:100.00% Y:100.00% *Did this work in previous version of GitExtensions (which)?* — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5758>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEMyXtYCbqBSwLmnh1JVIJ0ViLcPTCypks5uugUmgaJpZM4Yan-H> .

[vbjay]

Look good?

[RussKie]

I'd tweak it slightly

$path = Resolve-Path .\GitExtensions\GitExtensions.exe.config
[xml]$doc= Get-Content $path
$port=$doc.configuration.applicationSettings.'GitCommands.Properties.Settings'.setting | ?{ $_.name -eq 'IsPortable' } 
if ($port) {
    $port.value="True" 
    $doc.Save($path)
}

Writing in a browser without a PS to test

[vbjay]

    .\BuildInstallers.cmd

    Write-Host ----------------------------------------------------------------------
    Write-Host Alter Config
    Write-Host ----------------------------------------------------------------------
    $pth = Resolve-Path ..\GitExtensions\bin\Release\GitExtensions.exe.config
    $doc= [xml](Get-Content $pth)
    $port=$doc.configuration.applicationSettings.'GitCommands.Properties.Settings'.setting|? {$_.name -eq 'IsPortable'}
    if($port){
        $port.value="True"
        $doc.Save($pth)
    }

    Write-Host ----------------------------------------------------------------------
    Write-Host Make Portable Archive
    Write-Host -------------------------------------------------------------------
    .\MakePortableArchive.cmd Release $newVersion-beta1

    if($port){
        Write-Host ----------------------------------------------------------------------
        Write-Host Restore Config
        Write-Host -------------------------------------------------------------------
        $port.value="False"
        doc.Save($pth)
   }

[RussKie]

Do we care about the restoring the original flag? To me this is all a throwaway...

[vbjay]

If someone builds for their personal use, we don't want the run in release to be portable. Only the actual portable build.

[vbjay]

If they run MakePortable.cmd after build.cmd, this will not work. Why I was trying to make the cmd call the powershell script.