Make portable build use portable config #5759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
RussKie
approved these changes
Nov 13, 2018
|
Good change, but I would rather have changed the settings in all portable builds, including the AppVeyor builds by calling the snippets from MakePortable.cmd (in a new .ps script). |
vbjay
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5759 +/- ##
==========================================
+ Coverage 36.95% 36.95% +<.01%
==========================================
Files 619 619
Lines 47404 47404
Branches 6321 6321
==========================================
+ Hits 17517 17519 +2
Misses 29107 29107
+ Partials 780 778 -2 |
|
Calling powershell in a cmd is tough. I made a powershell script that can be run to set a build to portable. Sets release build to be portable Sets release build to not be portable Sets debug build to be portable Sets debug to not be portable. |
vbjay
changed the title
|
@RussKie @gerhardol Please let me know if there are any issues. |
RussKie
approved these changes
Nov 15, 2018
|
Squash? |
|
Absolutely :)
…On Thu, 15 Nov 2018 at 17:00, Jay Asbury ***@***.***> wrote:
Squash?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5759 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEMyXu_5vBsuuFilYJA4qWO0Tzu0M6oKks5uvQL5gaJpZM4Ya1CV>
.
|
Add Set-Portable script that sets IsPortable Call Set-Portable script for appveyor and releases Add more info to MakePortable script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5758
Changes proposed in this pull request:
Screenshots before and after (if PR changes UI):
What did I do to test the code and ensure quality:
Has been tested on (remove any that don't apply):