Side panel activate remotes: duplication

[gerhardol]

Current behaviour

After #6015
Activate&Fetch duplicated the remotes
(a second activation did not add a third)

Expected behaviour

No duplication

Steps to reproduce

Activate a remote

Screenshots

Did this work in previous version of GitExtensions

no, new in master

Environment

• Git Extensions 3.01.00.0
• Build 043c96c (AutoCompleteWord git-status must not lock git #6105 )
• Git 2.20.1.windows.1
• Microsoft Windows NT 10.0.17134.0
• .NET Framework 4.7.3260.0
• DPI 96dpi (no scaling)

Diagnostics

n/a

[amaiorano]

Huh weird. Will check it out.

[amaiorano]

Not sure how to repro this. Can you send me your 'git remote -v' or something so I can try to reproduce your environment?

[amaiorano]

I keep trying, but cannot reproduce. When this happens, do you see an exception in the VS output?

[amaiorano]

Oh I repro'd it! Happened once. Still having a difficult time reproducing.

[amaiorano]

So I must have tried over 100 times, and it happened only twice. When it did, I couldn't see why.

[vbjay]

Sounds like a threading issue.

…

On Mon, Jan 14, 2019 at 10:15 PM Antonio Maiorano ***@***.***> wrote: So I must have tried over 100 times, and it happened only twice. When it did, I couldn't see why. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#6106 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADdhsWBvi8MyMEvuPQLCtfkPF245nAujks5vDUfDgaJpZM4Z_7ON> .

[amaiorano]

I believe I got it. Putting the PR together.