Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic handling of failure to start a process #7795

Open
mstv opened this issue Feb 21, 2020 · 0 comments
Open

Generic handling of failure to start a process #7795

mstv opened this issue Feb 21, 2020 · 0 comments

Comments

@mstv
Copy link
Member

mstv commented Feb 21, 2020 •
edited

Current behaviour

#7714 wraps Process.Start in try { } catch (Exception ex) { MessageBox.Show() }.

Expected behaviour

We should replace all instances of Process with a generic wrapper -- at least all calls to Process.Start, e.g. with GitCommands.Executable.ProcessWrapper, which also needs generic error handling: #7574 (comment).
Related to #6527.
Abstraction for MessageBox.Show should be used: #7751 (comment).
@mstv mstv mentioned this issue Feb 21, 2020
Closed
@mstv mstv mentioned this issue Jun 28, 2020
Closed
@ghost ghost added the 🚧 status: in progress Issues which have associated PRs label Jun 28, 2020
@RussKie RussKie mentioned this issue Jul 26, 2020
Merged
@mstv mstv mentioned this issue Oct 11, 2020
Closed
RussKie added a commit to RussKie/gitextensions that referenced this issue Dec 6, 2020
@RussKie
Better exception presentation
ac9f534 
Trap and route as many exceptions as possible to the central handler.

For exceptions coming from the main thread it is possible to ignore those
and continue the app's execution, but for unhandled exceptions coming
from background threads the app will terminate.

The main focus of this work is to intercept exceptions originated from
`Executable` (i.e. executing git commands, etc.), and user scripts.
However it is not limited in this scope.

Resolves gitextensions#7795
RussKie added a commit to RussKie/gitextensions that referenced this issue Dec 6, 2020
@RussKie
Better exception presentation
e143bad 
Trap and route as many exceptions as possible to the central handler.

For exceptions coming from the main thread it is possible to ignore those
and continue the app's execution, but for unhandled exceptions coming
from background threads the app will terminate.

The main focus of this work is to intercept exceptions originated from
`Executable` (i.e. executing git commands, etc.), and user scripts.
However it is not limited in this scope.

Resolves gitextensions#7795
RussKie added a commit to RussKie/gitextensions that referenced this issue Dec 15, 2020
@RussKie
Better exception presentation
be0fab1 
Trap and route as many exceptions as possible to the central handler.

For exceptions coming from the main thread it is possible to ignore those
and continue the app's execution, but for unhandled exceptions coming
from background threads the app will terminate.

The main focus of this work is to intercept exceptions originated from
`Executable` (i.e. executing git commands, etc.), and user scripts.
However it is not limited in this scope.

Resolves gitextensions#7795
gerhardol pushed a commit to gerhardol/gitextensions that referenced this issue Dec 26, 2020
@RussKie @gerhardol
Better exception presentation
2a51e05 
Trap and route as many exceptions as possible to the central handler.

For exceptions coming from the main thread it is possible to ignore those
and continue the app's execution, but for unhandled exceptions coming
from background threads the app will terminate.

The main focus of this work is to intercept exceptions originated from
`Executable` (i.e. executing git commands, etc.), and user scripts.
However it is not limited in this scope.

Resolves gitextensions#7795
RussKie added a commit to RussKie/gitextensions that referenced this issue Dec 28, 2020
@RussKie
Better exception presentation
f48a0e5 
Trap and route as many exceptions as possible to the central handler.

For exceptions coming from the main thread it is possible to ignore those
and continue the app's execution, but for unhandled exceptions coming
from background threads the app will terminate.

The main focus of this work is to intercept exceptions originated from
`Executable` (i.e. executing git commands, etc.), and user scripts.
However it is not limited in this scope.

Resolves gitextensions#7795
RussKie added a commit to RussKie/gitextensions that referenced this issue Jan 2, 2021
@RussKie
Better exception presentation
6bc7201 
Trap and route as many exceptions as possible to the central handler.

For exceptions coming from the main thread it is possible to ignore those
and continue the app's execution, but for unhandled exceptions coming
from background threads the app will terminate.

The main focus of this work is to intercept exceptions originated from
`Executable` (i.e. executing git commands, etc.), and user scripts.
However it is not limited in this scope.

Resolves gitextensions#7795
RussKie added a commit to RussKie/gitextensions that referenced this issue Jan 2, 2021
@RussKie
Better exception presentation
9d9695c 
Trap and route as many exceptions as possible to the central handler.

For exceptions coming from the main thread it is possible to ignore those
and continue the app's execution, but for unhandled exceptions coming
from background threads the app will terminate.

The main focus of this work is to intercept exceptions originated from
`Executable` (i.e. executing git commands, etc.), and user scripts.
However it is not limited in this scope.

Contributes to gitextensions#7795
Co-authored-by: Michael Seibt <mstv@users.noreply.github.com>
@ghost ghost removed the 🚧 status: in progress Issues which have associated PRs label Jan 2, 2021
This was referenced Jan 5, 2021
Merged
Merged
@mstv mstv mentioned this issue Aug 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wrap and popup exceptions from Executable mstv/gitextensions
1 participant
@mstv