Process.Start with ExternalOperationException

[mstv]

Contributes to #7795, extracted from #8278

Proposed changes

• Use class Executable for OsShellUtil implementation
• Use OsShellUtil functions instead of plain Process.Start where applicable

Test methodology

• manual

Test environment(s)

• Git Extensions 33.33.33
• Build cca84cd
• Git 2.27.0.windows.1 (recommended: 2.28.0 or later)
• Microsoft Windows NT 10.0.19042.0
• .NET Framework 4.8.4300.0
• DPI 96dpi (no scaling)

---

✒️ I contribute this code under The Developer Certificate of Origin.

[codecov]

Codecov Report

Merging #8721 (7c89f65) into master (371c4b3) will increase coverage by 0.02%.
The diff coverage is 18.03%.

@@            Coverage Diff             @@
##           master    #8721      +/-   ##
==========================================
+ Coverage   55.71%   55.74%   +0.02%     
==========================================
  Files         900      900              
  Lines       65096    65076      -20     
  Branches    11737    11736       -1     
==========================================
+ Hits        36270    36278       +8     
+ Misses      25995    25967      -28     
  Partials     2831     2831              

Flag	Coverage Δ
production	42.75% <18.03%> (+0.02%)	⬆️
tests	94.95% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[gerhardol]

Just questions about try-catch changes
Open, OpenAs are handled in OsShellUtil

[RussKie]

This may not work in .NET, despite the docs saying it should, and having it working in .NET Framework, I stumble across it yesterday in fact.

I had to add the verb option to get it working:

-            using var process = new Process
-            {
-                EnableRaisingEvents = false,
-                StartInfo = { FileName = uri.AbsoluteUri }
-            };
-            process.Start();
+            var ps = new ProcessStartInfo(uri.AbsoluteUri)
+            {
+                UseShellExecute = true,
+                Verb = "open"
+            };
+            Process.Start(ps);
         }
 }

[mstv]

@msftbot merge in 1 day

[ghost]

Hello @mstv!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

• I won't merge this pull request until after the UTC date Thu, 07 Jan 2021 19:17:23 GMT, which is in 1 day

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".