Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.5.0: Create new branch here dialog display issues #9115

Closed
jrfnl opened this issue Apr 26, 2021 · 3 comments
Closed

3.5.0: Create new branch here dialog display issues #9115

jrfnl opened this issue Apr 26, 2021 · 3 comments
Labels
area: hdpi Issues related to scaling on high DPI

Comments

@jrfnl
Copy link

jrfnl commented Apr 26, 2021

Related to #8297, #8491

Current behaviour

When creating a new branch off a commit where there are multiple branches already, the display is off. (see screenshot)

Expected behaviour

That the new, extra information is displayed in a readable manner.

To be honest, I would expect the detailed commit information to only be displayed when using CTRL+B / Commands -> Create Branch and to not see this additional information at all when selecting a commit in the revision graph and right clicking "Create new branch here...". In that case, it's just noise as the user has already made a deliberate choice.

Steps to reproduce

  1. Take any commit.
  2. Create multiple branches on that same commit.
  3. Create yet another branch and see the display being off.

Screenshots

image

Did this work in previous version of GitExtensions

N/A, additional information was added in 3.5.0

Environment

  • Git Extensions 3.5.0.11713
  • Build 0a5ef9c (Dirty)
  • Git 2.31.1.windows.1
  • Microsoft Windows NT 10.0.19042.0
  • .NET Framework 4.8.4341.0
  • DPI 144dpi (150% scaling)
@jrfnl jrfnl changed the title 3.5.0: Create new branche here dialog display issues 3.5.0: Create new branch here dialog display issues Apr 26, 2021
@niedworok
Copy link

niedworok commented Apr 29, 2021

Additionally, in dark mode, disabled text is rendered black:

2021-04-29 14_20_19-Create branch

@gerhardol gerhardol added this to the 3.5.1 milestone May 2, 2021
@gerhardol
Copy link
Member

Additionally, in dark mode, disabled text is rendered black:

That may be a known bug in WinForms, no known way to verride the text color.

@RussKie
Copy link
Member

RussKie commented May 5, 2021

@pmiossec pmiossec added the area: hdpi Issues related to scaling on high DPI label May 12, 2021
pmiossec added a commit to pmiossec/gitextensions that referenced this issue May 12, 2021
when displaying the application with 150% scaling

fix gitextensions#9115
@ghost ghost added 🚧 status: in progress Issues which have associated PRs and removed 🚧 status: in progress Issues which have associated PRs labels May 12, 2021
@RussKie RussKie removed this from the 3.5.1 milestone May 16, 2021
pmiossec added a commit to pmiossec/gitextensions that referenced this issue May 22, 2021
when displaying the application with 150% scaling

fix gitextensions#9115
gerhardol pushed a commit to gerhardol/gitextensions that referenced this issue Jun 18, 2021
when displaying the application with 150% scaling

fix gitextensions#9115

(cherry picked from commit 289d028) gitextensions#9201
gerhardol pushed a commit to gerhardol/gitextensions that referenced this issue Jun 20, 2021
when displaying the application with 150% scaling

fix gitextensions#9115

(cherry picked from commit 289d028) gitextensions#9201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: hdpi Issues related to scaling on high DPI
Projects
None yet
Development

No branches or pull requests

5 participants