Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings not stored (on first run) #9288

Closed
mstv opened this issue Jun 14, 2021 · 0 comments · Fixed by #9318
Closed

Settings not stored (on first run) #9288

mstv opened this issue Jun 14, 2021 · 0 comments · Fixed by #9318
Assignees
@mstv
Labels
status: reproducible type: bug 🐛 type: regression regression, normally to latest official release
Milestone
3.5.1

Comments

@mstv
Copy link
Member

mstv commented Jun 14, 2021

Current behaviour

Settings are not stored if they had not existed in the settings file.

Expected behaviour

Settings are stored.

Steps to reproduce

  • extract portable build to new folder
  • run GE
  • change settings (even more confusing: change multiple on different pages and press Apply)
  • restart GE

Did this work in previous version of GitExtensions

< 3.5

Environment

  • Git Extensions 3.5.0.11713
  • Build 0a5ef9c (Dirty)
  • Git 2.30.1.windows.1
  • Microsoft Windows NT 10.0.19042.0
  • .NET Framework 4.8.4341.0
  • DPI 96dpi (no scaling)
@mstv mstv added type: bug 🐛 status: reproducible type: regression regression, normally to latest official release labels Jun 14, 2021
@mstv mstv added this to the 3.5.1 milestone Jun 14, 2021
mstv added a commit to mstv/gitextensions that referenced this issue Jun 16, 2021
@mstv
Create empty settings file
202d4f1 
instead of skipping the activation of the FileSystemWatcher

Fixes gitextensions#9288
@mstv mstv self-assigned this Jun 16, 2021
@mstv mstv mentioned this issue Jun 16, 2021
Merged
@ghost ghost added the 🚧 status: in progress Issues which have associated PRs label Jun 16, 2021
mstv added a commit to mstv/gitextensions that referenced this issue Jun 19, 2021
@mstv
Create empty AppSettings file
a548160 
in order to not let the FileSettingsCache skip the activation
of its FileSystemWatcher

Fixes gitextensions#9288
mstv added a commit to mstv/gitextensions that referenced this issue Jun 20, 2021
@mstv
Create empty AppSettings file
e395008 
in order to not let the FileSettingsCache skip the activation
of its FileSystemWatcher

Fixes gitextensions#9288
RussKie pushed a commit that referenced this issue Jun 27, 2021
@mstv
Create empty settings file if missing (#9289)
ac31455 
in order to not let the FileSettingsCache skip the activation
of its FileSystemWatcher

Fixes #9288
@ghost ghost removed the 🚧 status: in progress Issues which have associated PRs label Jun 27, 2021
mstv added a commit to mstv/gitextensions that referenced this issue Jun 30, 2021
@mstv
Create empty AppSettings file
6641bdf 
in order to not let the FileSettingsCache skip the activation
of its FileSystemWatcher

Fixes gitextensions#9288

(cherry picked from commit ac31455)
@mstv mstv mentioned this issue Jun 30, 2021
Merged
@ghost ghost added the 🚧 status: in progress Issues which have associated PRs label Jun 30, 2021
@ghost ghost removed the 🚧 status: in progress Issues which have associated PRs label Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mstv mstv

Labels
status: reproducible type: bug 🐛 type: regression regression, normally to latest official release
Projects
None yet
Milestone
3.5.1
Development

Successfully merging a pull request may close this issue.

Create empty settings file if missing mstv/gitextensions
1 participant
@mstv