Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create empty settings file if missing #9318

Merged
merged 1 commit into from Jul 2, 2021
Merged

Create empty settings file if missing #9318

merged 1 commit into from Jul 2, 2021

Conversation

mstv
Copy link
Member

@mstv mstv commented Jun 30, 2021

Fixes #9288

(PR #9289 for master)

Proposed changes

Create empty AppSettings file in order to not let the FileSettingsCache skip the activation of its FileSystemWatcher

Test methodology

  • manual

Test environment(s)

  • Git Extensions 33.33.33
  • Build 6641bdf
  • Git 2.31.1.windows.1
  • Microsoft Windows NT 10.0.19042.0
  • .NET 5.0.7
  • DPI 96dpi (no scaling)

✒️ I contribute this code under The Developer Certificate of Origin.

@mstv
Create empty AppSettings file
6641bdf 
in order to not let the FileSettingsCache skip the activation
of its FileSystemWatcher

Fixes gitextensions#9288

(cherry picked from commit ac31455)
@mstv mstv self-assigned this Jun 30, 2021
gerhardol
gerhardol approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as in 3.5

@RussKie RussKie merged commit 934eab7 into gitextensions:master Jul 2, 2021
@ghost ghost added this to the 3.6 milestone Jul 2, 2021
@mstv mstv deleted the fix/9288_no_settings branch July 3, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerhardol gerhardol gerhardol approved these changes

Assignees

@mstv mstv

Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Settings not stored (on first run)
3 participants
@mstv @gerhardol @RussKie