Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revision Links: Additional characters in URL from Commit Info in conjunction with '#' #9668

Closed
mstv opened this issue Oct 20, 2021 · 2 comments · Fixed by #9687
Closed

Revision Links: Additional characters in URL from Commit Info in conjunction with '#' #9668

mstv opened this issue Oct 20, 2021 · 2 comments · Fixed by #9687
Labels
.NET migration type: bug 🐛

Comments

@mstv
Copy link
Member

mstv commented Oct 20, 2021

Environment

  • Git Extensions 33.33.33
  • Build 9f7f727
  • Git 2.31.1.windows.1
  • Microsoft Windows NT 10.0.19043.0
  • .NET 5.0.11
  • DPI 96dpi (no scaling)

Issue description

The URL of a Revision Link contains addional characters from the Caption if the Caption contains the '#' character:

Revision Link URL

Revision Link definition

Steps to reproduce

  • setup as in the screenshot
  • copy the URL using the context menu of the Commit Info panel

Did this work in previous version of GitExtensions?

I think so. Before .NET 5?

Diagnostics

No response
@pmiossec
Copy link
Member

Did this work in previous version of GitExtensions?

I think so. Before .NET 5?

I can confirm. I have a version before .net 5 and it is working...

@RussKie
Copy link
Member

RussKie commented Oct 20, 2021

A bug. This would be related to dotnet/winforms#3632, and RichTextBox using a newer of version of RichEdit control since .NET Framework 4.7.

@RussKie RussKie added this to the vNext milestone Oct 20, 2021
@RussKie RussKie added .NET migration type: bug 🐛 up-for-grabs Easy tasks for those looking to get involved. Refer to https://up-for-grabs.net/ labels Oct 20, 2021
lekhmanrus added a commit to lekhmanrus/gitextensions that referenced this issue Oct 25, 2021
@lekhmanrus
Change Revision Links separator (gitextensions#9668)
165720f
@lekhmanrus lekhmanrus mentioned this issue Oct 25, 2021
Merged
@ghost ghost added the 🚧 status: in progress Issues which have associated PRs label Oct 25, 2021
lekhmanrus added a commit to lekhmanrus/gitextensions that referenced this issue Oct 25, 2021
@lekhmanrus
Change Revision Links separator (gitextensions#9668)
b295810
lekhmanrus added a commit to lekhmanrus/gitextensions that referenced this issue Oct 29, 2021
@lekhmanrus
Change Revision Links separator (gitextensions#9668)
0108b76
@mstv mstv closed this as completed in #9687 Nov 1, 2021
@ghost ghost removed the 🚧 status: in progress Issues which have associated PRs label Nov 1, 2021
@mstv mstv removed the up-for-grabs Easy tasks for those looking to get involved. Refer to https://up-for-grabs.net/ label Nov 1, 2021
@RussKie RussKie removed this from the vNext milestone Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
.NET migration type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change Revision Links separator (#9668) lekhmanrus/gitextensions
3 participants
@pmiossec @RussKie @mstv