Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Revision Links separator (#9668) #9687

Merged
merged 1 commit into from Nov 1, 2021

Conversation

lekhmanrus
Copy link
Contributor

@lekhmanrus lekhmanrus commented Oct 25, 2021

Fixes #9668

Proposed changes

  • use ||| instead of # to separate link text and link, because both potentially could contain hash symbol #
  • move out hardcoded separator to a variable, so it could be easily customized if needed

Before

Incorrect links that contain # symbol in the text.

After

Native behaviour.

Test methodology

  • Manual
  • Unit tests

Test environment(s)

  • GIT 2.33.1.windows.1
  • Windows 10.0.19043

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned lekhmanrus Oct 25, 2021
@gerhardol
Copy link
Member

Can you provide an example screenshot where the control is used and behavior is incorrect?

@lekhmanrus
Copy link
Contributor Author

@gerhardol you can find it here #9668
image

Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2
Works well. Thank you.

GitUI/Editor/RichTextBoxXhtmlSupportExtension.cs Outdated Show resolved Hide resolved
@RussKie
Copy link
Member

RussKie commented Oct 29, 2021

@mstv feel free to merge at will.

@mstv mstv merged commit a866c36 into gitextensions:master Nov 1, 2021
@ghost ghost added this to the vNext milestone Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revision Links: Additional characters in URL from Commit Info in conjunction with '#'
4 participants