Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RevDiff: Allow path filter for several files #10303

Merged
merged 1 commit into from Nov 5, 2022

Conversation

gerhardol
Copy link
Member

Companion to #10295

Proposed changes

Allow multi select files in rev diff to filter multiple files. See #10295 for a use case.
It is possible to filter folders in file tree today, but no GUI way to select multiple files.
Multiple files can be added in the advanced filter form though.
The first file is visible in the title
image
All files are visible in the tool tip
image

This exposes the possibility to add several files in rev diff file status list.
I believe this covers the important use case, I have thought about some enhancements and rejected them:

  • Possibility to add/remove files to the filter in any form.
    Adding would be simple, but not so easy to explain in the menu.
  • Context menu to remove files in the filter in any form.
    Would require some data structure changes (files stored as string right now), easier to understand in context menus though.
  • Multi-select files in FileTree
    Not enabled now.
  • Open a separate window (browse or old file history) with the selected files.
    Possible, but would require some call changes.

Screenshots

Before

Multiselect disables file filters.

After

image

Test methodology

Manual

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned gerhardol Oct 28, 2022
Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gerhardol gerhardol added this to the vNext milestone Nov 5, 2022
@gerhardol gerhardol merged commit fa210ff into gitextensions:master Nov 5, 2022
@gerhardol gerhardol deleted the feature/filter-multiple branch November 5, 2022 23:55
@mstv
Copy link
Member

mstv commented Dec 15, 2022

We should take this into v4.0.2 because it might resolve #10438 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants