Refactor scripts engine #11242
Merged
Refactor scripts engine #11242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
RussKie
force-pushed
the
refactor_scripts
branch
from
bbcf20a
to
f4ad1e9
Compare
RussKie
force-pushed
the
refactor_scripts
branch
2 times, most recently
from
445b54f
to
36b6b84
Compare
|
Some more tests need an |
|
Yep, working on it
|
RussKie
force-pushed
the
refactor_scripts
branch
4 times, most recently
from
94e7a83
to
74b0fac
Compare
mstv
reviewed
Oct 7, 2023
* Make the scripts manager and the runner DI friendly. * Refactor and clean up the API surface
RussKie
force-pushed
the
refactor_scripts
branch
from
74b0fac
to
29add70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a foundation for #10866 as well as #11239.
Proposed changes
HotkeySettingsManageris not DI-friendly. It must be refactored to become one, and I have some private drafts that'd enable that; so that is coming in the future.HotkeySettingsManagerDI-friendly and allow load/persistence of per-repo scripts.Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.