-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialise scripts #10866
base: master
Are you sure you want to change the base?
Serialise scripts #10866
Conversation
Reviving an old changeset. I had a quick test, and it seems to work. |
Recommend guid ids for unique scripts so if same script on multiple layers can get closest to repo setting instead of getting duplicates and instead of using numbers that can colide as different scripts entirely. My 112 global level may be overridden in x repo distributed because number is 112. If we have a move/copy script around functionality to different layers so a global script has same guid as a distributed in repo then the distributed would win but it would just show 1 script row for the script per level it exists in. Basically overridable scripts. |
<AskConfirmation>false</AskConfirmation> | ||
<RunInBackground>true</RunInBackground> | ||
<IsPowerShell>false</IsPowerShell> | ||
<HotkeyCommandIdentifier>10001</HotkeyCommandIdentifier> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we need to create unique numbers - at least per category - because all hotkeys have global scope and one cannot know which ids have already been used for repo-specific scripts of another repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Numbers are a BAD idea especially since you have settings levels and across clones of repos. Instead guids should be the new IDs of the scripts. Hotkeys should not be stored across clones. Local and global would make sense. Across repos you will have potential collisions between global and local on different computers.
One needs to select the Scripts settings page once in order to be able to save other settings.
|
The icon combobox dropdown should be filled only once, i.e. if empty. |
Thank you. Keep these coming
|
d280bbc
to
5076994
Compare
48236f9
to
4f05dca
Compare
4f05dca
to
dcc7cb0
Compare
Proposed changes
RepoDistSettings
->DistributedSettings
,RepoDistSettingsPage
->DistributedSettingsPage
Screenshots
Before
After
Test methodology
Merge strategy
Don't squash
✒️ I contribute this code under The Developer Certificate of Origin.