feat: Dashboard revisited #3693
Conversation
| private readonly TranslationString directoryIsNotAValidRepositoryCaption = new TranslationString("Open"); | ||
| private readonly TranslationString directoryIsNotAValidRepository = new TranslationString("The selected item is not a valid git repository.\n\nDo you want to abort and remove it from the recent repositories list?"); | ||
| private readonly TranslationString directoryIsNotAValidRepositoryOpenIt = new TranslationString("The selected item is not a valid git repository.\n\nDo you want to open it?"); | ||
| private readonly TranslationString _showCurrentBranch = new TranslationString("Show current branch"); |
There was a problem hiding this comment.
These are no longer relevant. Do I need to remove all referenced translations myself or will it be done automatically by the translation app?
There was a problem hiding this comment.
The translation app should handle that.
|
The translation strings are what is used to generate the list of
translations the site uses.
…On Sun, May 7, 2017, 6:07 AM RussKie ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In GitUI/CommandsDialogs/BrowseDialog/DashboardControl/Dashboard.cs
<#3693 (comment)>
:
> @@ -26,321 +26,217 @@ public partial class Dashboard : GitModuleControl
private readonly TranslationString issues = new TranslationString("Issues");
private readonly TranslationString openRepository = new TranslationString("Open repository");
private readonly TranslationString translate = new TranslationString("Translate");
- private readonly TranslationString directoryIsNotAValidRepositoryCaption = new TranslationString("Open");
- private readonly TranslationString directoryIsNotAValidRepository = new TranslationString("The selected item is not a valid git repository.\n\nDo you want to abort and remove it from the recent repositories list?");
- private readonly TranslationString directoryIsNotAValidRepositoryOpenIt = new TranslationString("The selected item is not a valid git repository.\n\nDo you want to open it?");
- private readonly TranslationString _showCurrentBranch = new TranslationString("Show current branch");
These are no longer relevant. Do I need to remove all referenced
translations myself or will it be done automatically by the translation app?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3693 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADdhsf4FFUkIbd5deaO4rPCIeqYUaX1fks5r3ZfggaJpZM4NTFmP>
.
|
|
Really? So the translation app will delete unused translation strings from
the source code?
…On Mon, May 8, 2017, 2:40 AM Janusz Białobrzewski ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In GitUI/CommandsDialogs/BrowseDialog/DashboardControl/Dashboard.cs
<#3693 (comment)>
:
> @@ -26,321 +26,217 @@ public partial class Dashboard : GitModuleControl
private readonly TranslationString issues = new TranslationString("Issues");
private readonly TranslationString openRepository = new TranslationString("Open repository");
private readonly TranslationString translate = new TranslationString("Translate");
- private readonly TranslationString directoryIsNotAValidRepositoryCaption = new TranslationString("Open");
- private readonly TranslationString directoryIsNotAValidRepository = new TranslationString("The selected item is not a valid git repository.\n\nDo you want to abort and remove it from the recent repositories list?");
- private readonly TranslationString directoryIsNotAValidRepositoryOpenIt = new TranslationString("The selected item is not a valid git repository.\n\nDo you want to open it?");
- private readonly TranslationString _showCurrentBranch = new TranslationString("Show current branch");
The translation app should handle that.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3693 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADdhsYNCtjL3y5Q3spHc8MOFcsGeGiYwks5r3rjwgaJpZM4NTFmP>
.
|
|
@vbjay my question was about removing unused strings from *.xlf files, not from *.cs |
|
@RussKie could you take a look at CI checks? - they are failing. |
|
|
||
| Load += Dashboard_Load; | ||
| ApplyTheme(); |
There was a problem hiding this comment.
TranslationTest.CreateInstanceOfClass creates Dashboard which shows a modal dialog. It causes that the test never ends.
There was a problem hiding this comment.
Yes, I didn't run unit tests I must admit... 🤦♂️
I'll look into it tomorrow
|
Copy Plugins Bug was already Fixed a few days Back, so I'd suggest getting those changes to fix your Trello build |
|
Yep, planning to do that shortly. |
RussKie
force-pushed
the
feat_start_page
branch
2 times, most recently
from
d4af3f9
to
7e5a6f6
Compare
|
Most likely I'll fork your fork, and I might hold up a diagnostics PR, to see the error eliminate it and keep it updated. If successfull, I'll send back the fork |
|
CommandsDialogs\BrowseDialog\DashboardControl\RecentRepositoryItem.cs(256,17): error CS1043: { or ; expected [C:\projects\gitextensions\GitUI\GitUI.csproj] CommandsDialogs\BrowseDialog\DashboardControl\RecentRepositoryItem.cs(256,17): error CS1513: } expected [C:\projects\gitextensions\GitUI\GitUI.csproj] CommandsDialogs\BrowseDialog\DashboardControl\RecentRepositoryItem.cs(257,16): error CS1002: ; expected [C:\projects\gitextensions\GitUI\GitUI.csproj] CommandsDialogs\BrowseDialog\DashboardControl\RecentRepositoryItem.cs(275,10): error CS1513: } expected [C:\projects\gitextensions\GitUI\GitUI.csproj] Here are your Appveyor Errors |
|
Yep, thanks. I'm currently doing work, fixing scaling issues with large
fonts, it is wip.
…On 21/05/2017 12:08 AM, "CDAGaming" ***@***.***> wrote:
CommandsDialogs\BrowseDialog\DashboardControl\RecentRepositoryItem.cs(256,17):
error CS1043: { or ; expected [C:\projects\gitextensions\
GitUI\GitUI.csproj]
CommandsDialogs\BrowseDialog\DashboardControl\RecentRepositoryItem.cs(256,17):
error CS1513: } expected [C:\projects\gitextensions\GitUI\GitUI.csproj]
CommandsDialogs\BrowseDialog\DashboardControl\RecentRepositoryItem.cs(257,16):
error CS1002: ; expected [C:\projects\gitextensions\GitUI\GitUI.csproj]
CommandsDialogs\BrowseDialog\DashboardControl\RecentRepositoryItem.cs(275,10):
error CS1513: } expected [C:\projects\gitextensions\GitUI\GitUI.csproj]
Here are your Appveyor Errors
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3693 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEMyXh_4s5uPmS6k22yZebkuCQa7r7UWks5r7vPRgaJpZM4NTFmP>
.
|
RussKie
force-pushed
the
feat_start_page
branch
2 times, most recently
from
fc16321
to
82a96b2
Compare
|
@CDAGaming, thanks, but it is all good now. 150% scaling, GE custom font +5 |
|
@RussKie Conflicts xD |
Oh well.... |
|
@RussKie Well, as this would be a major change, i think it's just being waited on. If they didn't feel this was neccesary, they'd close it. Personally, i like your changes and you did well on it |
|
@RussKie #3038 is a very useful pull request, which remains unmerged for over 1.5 years. @EbenZhang still does a very good job supporting its conflictless mergeability. Btw., your dashboard has a few problems on top of mono (5.0.1.1, Cinnamon, Fedora 25): This also means that the "Contribute" area goes outside of the window area when making the window smaller: |
|
Also, clone github repository would be good to still have. |
I do quite the opposite - I primarily use recents (as do all our engineers who use GE). In event when a user has a lot of categories recents may be scrolled off the view, I am not sure that would be a good UX...
The listview is scrollable and categories (groups) are collapsible. Feel free to download the build I provided earlier and test it.
Sorry, but this is not going to happen anytime soon. |
|
Looks good to me. I would prefer if submodules did not appear on the recents list, just the top super projects so the recent list is manageable in size (I use a lot of submodules in many levels at work). But I am sure that some will dislike that too. A completely different issue. |
|
The submodules are in my recent history because I did open them separately.
And then added to favourites for presentation purposes
…On Thu, 10 May 2018 8:42 am Gerhard Olsson ***@***.***> wrote:
Looks good to me.
I would prefer if submodules did not appear on the recents list, just the
top super projects so the recent list is manageable in size (I use a lot of
submodules in many levels at work). But I am sure that some will dislike
that too. A completely different issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3693 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEMyXgo86KSYQK6wz5UcUWOW7bY91_oNks5tw3C6gaJpZM4NTFmP>
.
|
It is still here, my build used for the demonstration didn't have any plugins, that's why the GH link is missing |
|
@gerhardol it seems that my commit button count "sticks" and doesn't always seem to update in this PR. |
Works for me in this branch FYI: Menu item "Open in GitExtensions" still do not work -- |
Could you please elaborate how it is related to this PR? |
Diff tab missing is new - can of course be something else For "Menu item "Open in GitExtensions" still do not work" I interpreted your comment on #4860 to be related to this issue: |
I am afraid I am not observing this issue in either this branch or the master... I can't see anything in this PR that may have caused this. |
Dashboard completely overhauled to provide more streamlined and simpler UX. Recent repositories and categorised repositories collections are combined. The repositories list now only contains list of recent repositories and is sync'ed with the list of repositories dropdown to provide the consistent UX. The list is managed via the FormRecentReposSettings. The new dashboard has: * two distinct themes - light and dark. A theme is selected automatically based on the current Windows theme. Closes gitextensions#3658 Related issues/feature requests: * Closes gitextensions#633 as obsolete * Closes gitextensions#1062 as obsolete * Fixes gitextensions#1382 * Closes gitextensions#1970 as obsolete * Fixes gitextensions#2228 * Fixes gitextensions#2328 * Fixes gitextensions#3624 * Closes gitextensions#3648 as obsolete * Fixes gitextensions#3932
|
Just a few notes about the new dashboard
|
|
@francoas could you open a new issue please so this comment doesn't get lost? |
|
Done: #5084 |
Dashboard completely overhauled to provide more streamlined and simpler UX. Recent repositories and categorised repositories collections are combined. The repositories list now only contains list of recent repositories and is sync'ed with the list of repositories dropdown to provide the consistent UX.
The list is managed via the FormRecentReposSettings.
The new dashboard has:
Also:
Closes #3658
Related issues/feature requests:
The following are still outstanding and may get eventually be addressed if the new dashboard is retrofitted on to 2.5x branch
Features to consider once it is merged in
Screenshots:
Windows:
Update: 7 May 2018
