Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RSS feeds functionality #4008

Merged
merged 1 commit into from Sep 23, 2017
Merged

Remove RSS feeds functionality #4008

merged 1 commit into from Sep 23, 2017

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Sep 19, 2017

Changes proposed in this pull request:

  • RSS feeds are retired

As agreed #3693 (comment)

@RussKie RussKie added this to the 2.51 milestone Sep 19, 2017
@jbialobr jbialobr merged commit 4e48ea9 into gitextensions:master Sep 23, 2017
@l-inc
Copy link

l-inc commented Oct 2, 2017

@RussKie
I don't get the point of the following change in GitCommands/Repository/Repositories.cs:
repositories_diff
As far as I understand, the pull request was supposed to get rid of the only alternative RepositoryCategoryType, namely RssFeed, which also renders enum RepositoryCategoryType unnecessary. At the same time the above diff introduces a dependency on this enumeration assuming there are still other types beyond the type Repositories, although the only other type is RssFeed for some reason still lingering in the enum RepositoryCategoryType.

I'm asking because this diff also creates a conflict with the #3693 of yours.

@RussKie
Copy link
Member Author

RussKie commented Oct 3, 2017 via email

@RussKie RussKie deleted the Remove_RSS_feeds branch October 3, 2017 03:23
RussKie added a commit to RussKie/gitextensions that referenced this pull request Mar 12, 2018
@RussKie
Deprecate repository type
f47a540 
RSS feed functionality has been deprecated in gitextensions#4008.
However a number of residuals have been left behind, such as:
* RepositoryCategoryType.RssFeed, and
* RepositoryType.RssFeed

* `RepositoryCategoryType` is deprecated and removed - after the removal of RssFeed member it become useless.
* `RepositoryType` is deprecated and removed.
* `Repository` type has been simplified to only contain the following members:
    - Path: path to the repository
    - Category: category has become a property of a repository and it now gets persisted along with it
    - Anchor: most/least used

NB: some changes to DashboardItem are artificial to make the code compile - DashboardItem is being deleted in the subsequent PR.
RussKie added a commit to RussKie/gitextensions that referenced this pull request Mar 22, 2018
@RussKie
Deprecate repository type
c06b14d 
RSS feed functionality has been deprecated in gitextensions#4008.
However a number of residuals have been left behind, such as:
* RepositoryCategoryType.RssFeed, and
* RepositoryType.RssFeed

* `RepositoryCategoryType` is deprecated and removed - after the removal of RssFeed member it become useless.
* `RepositoryType` is deprecated and removed.
* `Repository` type has been simplified to only contain the following members:
    - Path: path to the repository
    - Category: category has become a property of a repository and it now gets persisted along with it
    - Anchor: most/least used

NB: some changes to DashboardItem are artificial to make the code compile - DashboardItem is being deleted in the subsequent PR.
RussKie added a commit to RussKie/gitextensions that referenced this pull request Apr 2, 2018
@RussKie
Deprecate repository type
43a3753 
RSS feed functionality has been deprecated in gitextensions#4008.
However a number of residuals have been left behind, such as:
* RepositoryCategoryType.RssFeed, and
* RepositoryType.RssFeed

* `RepositoryCategoryType` is deprecated and removed - after the removal
of RssFeed member it become useless.
* `RepositoryType` is deprecated and removed.
* `Repository` type has been simplified to only contain the following
members:
    - Path: path to the repository
    - Category: category has become a property of a repository and it
now gets persisted along with it
    - Anchor: most/least used

NB: some changes to DashboardItem are artificial to make the code compile
- DashboardItem is being deleted in the subsequent PR.
RussKie added a commit to RussKie/gitextensions that referenced this pull request Apr 2, 2018
@RussKie
Deprecate repository type
59c76a5 
RSS feed functionality has been deprecated in gitextensions#4008.
However a number of residuals have been left behind, such as:
* RepositoryCategoryType.RssFeed, and
* RepositoryType.RssFeed

* `RepositoryCategoryType` is deprecated and removed - after the removal
of RssFeed member it become useless.
* `RepositoryType` is deprecated and removed.
* `Repository` type has been simplified to only contain the following
members:
    - Path: path to the repository
    - Category: category has become a property of a repository and it
now gets persisted along with it
    - Anchor: most/least used

NB: some changes to DashboardItem are artificial to make the code compile
- DashboardItem is being deleted in the subsequent PR.
RussKie added a commit to RussKie/gitextensions that referenced this pull request Apr 3, 2018
@RussKie
Deprecate repository type
ab56236 
RSS feed functionality has been deprecated in gitextensions#4008.
However a number of residuals have been left behind, such as:
* RepositoryCategoryType.RssFeed, and
* RepositoryType.RssFeed

* `RepositoryCategoryType` is deprecated and removed - after the removal
of RssFeed member it become useless.
* `RepositoryType` is deprecated and removed.
* `Repository` type has been simplified to only contain the following
members:
    - Path: path to the repository
    - Category: category has become a property of a repository and it
now gets persisted along with it
    - Anchor: most/least used

NB: some changes to DashboardItem are artificial to make the code compile
- DashboardItem is being deleted in the subsequent PR.
RussKie added a commit to RussKie/gitextensions that referenced this pull request Apr 7, 2018
@RussKie
Deprecate repository type
fa04748 
RSS feed functionality has been deprecated in gitextensions#4008.
However a number of residuals have been left behind, such as:
* RepositoryCategoryType.RssFeed, and
* RepositoryType.RssFeed

* `RepositoryCategoryType` is deprecated and removed - after the removal
of RssFeed member it become useless.
* `RepositoryType` is deprecated and removed.
* `Repository` type has been simplified to only contain the following
members:
    - Path: path to the repository
    - Category: category has become a property of a repository and it
now gets persisted along with it
    - Anchor: most/least used

NB: some changes to DashboardItem are artificial to make the code compile
- DashboardItem is being deleted in the subsequent PR.
RussKie added a commit to RussKie/gitextensions that referenced this pull request Apr 10, 2018
@RussKie
Deprecate repository type
608d85e 
RSS feed functionality has been deprecated in gitextensions#4008.
However a number of residuals have been left behind, such as:
* RepositoryCategoryType.RssFeed, and
* RepositoryType.RssFeed

* `RepositoryCategoryType` is deprecated and removed - after the removal
of RssFeed member it become useless.
* `RepositoryType` is deprecated and removed.
* `Repository` type has been simplified to only contain the following
members:
    - Path: path to the repository
    - Category: category has become a property of a repository and it
now gets persisted along with it
    - Anchor: most/least used

NB: some changes to DashboardItem are artificial to make the code compile
- DashboardItem is being deleted in the subsequent PR.
RussKie added a commit to RussKie/gitextensions that referenced this pull request Apr 10, 2018
@RussKie
Deprecate repository type
61c5cd9 
RSS feed functionality has been deprecated in gitextensions#4008.
However a number of residuals have been left behind, such as:
* RepositoryCategoryType.RssFeed, and
* RepositoryType.RssFeed

* `RepositoryCategoryType` is deprecated and removed - after the removal
of RssFeed member it become useless.
* `RepositoryType` is deprecated and removed.
* `Repository` type has been simplified to only contain the following
members:
    - Path: path to the repository
    - Category: category has become a property of a repository and it
now gets persisted along with it
    - Anchor: most/least used

NB: some changes to DashboardItem are artificial to make the code compile
- DashboardItem is being deleted in the subsequent PR.
RussKie added a commit to RussKie/gitextensions that referenced this pull request Apr 12, 2018
@RussKie
Deprecate repository type
691747a 
RSS feed functionality has been deprecated in gitextensions#4008.
However a number of residuals have been left behind, such as:
* RepositoryCategoryType.RssFeed, and
* RepositoryType.RssFeed

* `RepositoryCategoryType` is deprecated and removed - after the removal
of RssFeed member it become useless.
* `RepositoryType` is deprecated and removed.
* `Repository` type has been simplified to only contain the following
members:
    - Path: path to the repository
    - Category: category has become a property of a repository and it
now gets persisted along with it
    - Anchor: most/least used

NB: some changes to DashboardItem are artificial to make the code compile
- DashboardItem is being deleted in the subsequent PR.
RussKie added a commit to RussKie/gitextensions that referenced this pull request Apr 14, 2018
@RussKie
Deprecate repository type
1ba484d 
RSS feed functionality has been deprecated in gitextensions#4008.
However a number of residuals have been left behind, such as:
* RepositoryCategoryType.RssFeed, and
* RepositoryType.RssFeed

* `RepositoryCategoryType` is deprecated and removed - after the removal
of RssFeed member it become useless.
* `RepositoryType` is deprecated and removed.
* `Repository` type has been simplified to only contain the following
members:
    - Path: path to the repository
    - Category: category has become a property of a repository and it
now gets persisted along with it
    - Anchor: most/least used

NB: some changes to DashboardItem are artificial to make the code compile
- DashboardItem is being deleted in the subsequent PR.

Part of gitextensions#4766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.51.RC1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RussKie @l-inc @jbialobr