Added toolStripFileExplorer to complete the feature-request

[joshia89]

Fixes #3585 .

Changes proposed in this pull request:

• Add a "File Explorer" shortcut in the toolbar (next to "Git bash")

Screenshots before and after (if PR changes UI):

How did I test this code:

• Make sure the button appears correctly
• If it is a valid working directory, the file explorer is enabled and behaves as expected
• If it is not a valid working directory, the file explorer button is disabled

[RussKie]

there is already a handler doing just this - FileExplorerToolStripMenuItemClick
please bind the event to the existing handler

[RussKie]

this text needs to be translated

the easiest way is probably do the following:

        private FormBrowse()
        {
            InitializeComponent();
            Translate();

            toolStripFileExplorer.ToolTipText = fileExplorerToolStripMenuItem.Text;
        }

@jbialobr what do you think?

[jbialobr]

ToolTipTexts assigned this way are translated automagically. #3745

[RussKie]

For the automagic to work, someone will still need to provide translations, won't they?
fileExplorerToolStripMenuItem performs exactly the same function and has the required text, which is already translated. Hence my suggestion to copy and assign the existing translation to the new element.

...Or does the automagic work somehow differently?

[jbialobr]

For the automagic to work, someone will still need to provide translations, won't they?

Yes, that is true. But I would not mix Text and ToolTipText. It so happened they share the same text, but it should be handled on the translation side to prompt the same translation for the same texts when a translator is translating.

[joshia89]

Thanks @RussKie and @jbialobr. RussKie, do you want me to make any changes here?

P.S the other requested change has been committed

[RussKie]

no worries then

…

On 23 September 2017 at 22:30, Janusz Białobrzewski < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In GitUI/CommandsDialogs/FormBrowse.Designer.cs <#4018 (comment)> : > @@ -528,6 +530,17 @@ private void InitializeComponent() this.toolStripSeparator2.Name = "toolStripSeparator2"; this.toolStripSeparator2.Size = new System.Drawing.Size(6, 25); // + // toolStripFileExplorer + // + this.toolStripFileExplorer.CheckOnClick = true; + this.toolStripFileExplorer.Enabled = false; + this.toolStripFileExplorer.Image = global::GitUI.Properties.Resources.Folder; + this.toolStripFileExplorer.ImageTransparentColor = System.Drawing.Color.Gray; + this.toolStripFileExplorer.Name = "toolStripFileExplorer"; + this.toolStripFileExplorer.Size = new System.Drawing.Size(23, 22); + this.toolStripFileExplorer.ToolTipText = "File Explorer"; For the automagic to work, someone will still need to provide translations, won't they? Yes, that is true. But I would not mix Text and ToolTipText. It so happened they share the same text, but it should be handled on the translation side to prompt the same translation for the same texts when a translator is translating. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4018 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEMyXu5oUmB9ACjzH_AgktjvXd_wzWz4ks5slPoBgaJpZM4Pg2h4> .