ExternalLinksParser rework #4425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename ExtLink* objects and the namespace to provide clearer idea about the intent.
ExternalLinksParser implementation is convoluted and is a mix of a number of different concerns - e.g. loading and saving definition to/from files, keeping track of current definitions, aggregating defintions across settings layers, parsing GitRevision for external links. * ExternalLinksParser renamed to ExternalLinksManager. The manager remains stateful maintaining a collection of definitions at the top settings level. * Extract Load and Save functionality into ExternalLinksLoader. Functionality is simplified to deal with only supplied layer of settings. * Extract ExternalLinksParser.Parse to GitRevisionExternalLinksParser. Used by CommitInfo while loading commit information and applying configured external links. * Extract effective external links configuration loading into ConfiguredLinkDefinitionsProvider. Definitions are loaded across different layers of configuration. This is used by GitRevisionExternalLinksParser. Added unit and integration tests.
gerhardol
reviewed
Feb 4, 2018
| { | ||
| _definitions.Add(definition); | ||
| } | ||
| // TODO: else notify the user? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExternalLinksParserimplementation is convoluted and is a mix of a number of different concerns - e.g. loading and saving definition to/from files, keeping track of current definitions, aggregating defintions across settings layers, parsingGitRevisionfor external links.ExternalLinksParserrenamed toExternalLinksManager. The manager remains stateful maintaining a collection of definitions at the top settings level.LoadandSavefunctionality intoExternalLinksLoader. Functionality is simplified to deal with only supplied layer of settings.ExternalLinksParser.ParsetoGitRevisionExternalLinksParser. Used byCommitInfowhile loading commit information and applying configured external links.ConfiguredLinkDefinitionsProvider. Definitions are loaded across differentlayers of configuration. This is used by
GitRevisionExternalLinksParser.Added unit and integration tests.
What did I do to test the code and ensure quality:
Has been tested on (remove any that don't apply):