Commits on Feb 2, 2018

1. refactor: Rename ExtLink* objects …

   Rename ExtLink* objects and the namespace to provide clearer idea about
   the intent.

   

   RussKie committed Feb 2, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for 80ad372
   • Browse repository at this point

   Copy the full SHA

   80ad372 View commit details

   Browse the repository at this point in the history

2. refactor: ExternalLinksParser rework …

   ExternalLinksParser implementation is convoluted and is a mix of a number
   of different concerns - e.g. loading and saving definition to/from files,
   keeping track of current definitions, aggregating defintions across settings
   layers, parsing GitRevision for external links.
   
   * ExternalLinksParser renamed to ExternalLinksManager. The manager
   remains stateful maintaining a collection of definitions at the top settings level.
   * Extract Load and Save functionality into ExternalLinksLoader.
   Functionality is simplified to deal with only supplied layer of settings.
   * Extract ExternalLinksParser.Parse to GitRevisionExternalLinksParser.
   Used by CommitInfo while loading commit information and applying
   configured external links.
   * Extract effective external links configuration loading into
   ConfiguredLinkDefinitionsProvider. Definitions are loaded across different
   layers of configuration. This is used by GitRevisionExternalLinksParser.
   
   Added unit and integration tests.

   

   RussKie committed Feb 2, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for 0a6997e
   • Browse repository at this point

   Copy the full SHA

   0a6997e View commit details

   Browse the repository at this point in the history