Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FormFixHome is messed up HiDPI #4755

Merged
merged 1 commit into from
Apr 4, 2018

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Apr 2, 2018

Relates to #4099
Fixes #4690

Screenshots before and after (if PR changes UI):
150% scaling (before / after)
image

What did I do to test the code and ensure quality:

  • run it manually at various scaling

Has been tested on (remove any that don't apply):

  • Windows 10
  • 34" 4K monitor

@codecov
Copy link

codecov bot commented Apr 2, 2018

Codecov Report

Merging #4755 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4755      +/-   ##
==========================================
- Coverage   29.92%   29.92%   -0.01%     
==========================================
  Files         516      516              
  Lines       41644    41644              
  Branches     5901     5901              
==========================================
- Hits        12463    12460       -3     
- Misses      28671    28673       +2     
- Partials      510      511       +1
Impacted Files Coverage Δ
GitUI/Editor/Diff/LinePrefixHelper.cs 95.83% <0%> (-4.17%) ⬇️
GitUI/Hotkey/HotkeySettingsManager.cs 79.67% <0%> (-0.55%) ⬇️
GitUI/Editor/FileViewer.cs 19.49% <0%> (-0.19%) ⬇️
...itUI/UserControls/RevisionGridClasses/DvcsGraph.cs 23.85% <0%> (-0.16%) ⬇️
GitUI/FormStatus.cs 12.5% <0%> (ø) ⬆️
GitCommands/Settings/AppSettings.cs 26.94% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfd250b...5760d80. Read the comment docs.

@RussKie RussKie self-assigned this Apr 2, 2018
Copy link
Member

@drewnoakes drewnoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my 200% scaled screen.

image

@drewnoakes drewnoakes mentioned this pull request Apr 4, 2018
28 tasks
@drewnoakes
Copy link
Member

This fixes #4690.

@drewnoakes drewnoakes added the area: hdpi Issues related to scaling on high DPI label Apr 4, 2018
@RussKie
Copy link
Member Author

RussKie commented Apr 4, 2018

Awesome, thanks

@RussKie RussKie merged commit f176cb3 into master Apr 4, 2018
@RussKie RussKie deleted the fix_4099_FormFixHome_messed_up_on_HiDPI branch April 4, 2018 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: hdpi Issues related to scaling on high DPI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants