Consistent icons and text for shell extension menu

[mstv]

Fixes #5117.

Changes proposed in this pull request:

• Use the dashboard's icon for the item GitExt Open repository (ranamed from GitExt Browse) in the Explorer context menu, too.
  
  old:
  
  new:
  

• Converted GitUI\Resources\Icons\DashboardFolderGit.png
  and GitUI\Resources\Icons\PatchApply.png to .ico files
  and replaced GitExtensionsShellEx/Resources/IconBrowseFileExplorer.ico

• Replaced GitExtensionsShellEx\Resources\IconBrowseFileExplorer.ico with Logo\git-extensions-logo.ico

• Added IconPatchApply.ico to the menu item Apply patch...

What did I do to test the code and ensure quality:

• Checked the .ico files with a few graphics viewers including the Explorer.
• Built the installer, installed GE and used the shell extension menu.

Has been tested on:

• GIT: (2.17.1.w.2-x64)
• OS: Windows 7
• .net: (4.7)

[codecov]

Codecov Report

Merging #5124 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5124      +/-   ##
==========================================
- Coverage   35.43%   35.43%   -0.01%     
==========================================
  Files         600      600              
  Lines       45774    45774              
  Branches     6256     6256              
==========================================
- Hits        16220    16218       -2     
  Misses      28809    28809              
- Partials      745      747       +2

[RussKie]

Could you please post a screenshot with the fix?
I've also updated #5117 with one more inconsistency

[drewnoakes]

This change is also present in #5087.

[RussKie]

@mstv could you pull down the latest master and check whether your proposed change is still relevant.
Thank you

[gerhardol]

This could be merged as is, but #5368 is related

[RussKie]

Could you please copy it to Resources folder as well

[mstv]

No problem, if you really want to have a copy of it.
I'm afraid, this will make this issue reoccur when the icons will be changed again.

[RussKie]

Let's merge it as is, and deal with #5368 separately

[RussKie]

Yes, I'm fine with this. I think it is better than changing an icon without realising it is used in multiple places

…

On Fri, Aug 31, 2018, 8:28 AM Michael Seibt ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In GitExtensionsShellEx/GitExtensionsShellEx.rc <#5124 (comment)> : > -IDI_ICONBROWSEFILEEXPLORER ICON "Resources\\IconBrowseFileExplorer.ico" -IDI_ICONBRANCHCREATE ICON "Resources\\IconBranchCreate.ico" -IDI_ICONBRANCHCHECKOUT ICON "Resources\\IconBranchCheckout.ico" -IDI_ICONREVISIONCHECKOUT ICON "Resources\\IconRevisionCheckout.ico" -IDI_ICONABOUT ICON "Resources\\IconAbout.ico" -IDI_ICONCLONEREPOGIT ICON "Resources\\IconCloneRepoGit.ico" -IDI_ICONCOMMIT ICON "Resources\\IconCommit.ico" -IDI_ICONFILEHISTORY ICON "Resources\\IconFileHistory.ico" -IDI_ICONPULL ICON "Resources\\IconPull.ico" -IDI_ICONPUSH ICON "Resources\\IconPush.ico" -IDI_ICONTRESETFILETO ICON "Resources\\IconResetFileTo.ico" -IDI_ICONSETTINGS ICON "Resources\\IconSettings.ico" -IDI_ICONVIEWCHANGES ICON "Resources\\IconDiff.ico" -IDI_ICONSTASH ICON "Resources\\IconStash.ico" -IDI_ICONCREATEREPOSITORY ICON "Resources\\IconRepoCreate.ico" +IDI_GITEXTENSIONS ICON "..\\Logo\\git-extensions-logo.ico" No problem, if you really want to have a copy of it. I'm afraid, this will make this issue reoccur when the icons will be changed again. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5124 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEMyXjwDiIgMS6YoBKs14_t3QMDHuVMjks5uWGchgaJpZM4U8LWZ> .

[RussKie]

Thank you