Dashboard category context menu

[NikolayXHD]

Fixes #4947
Fixes #4948

Depends on #5428

Screenshots

Tested on Windows 7

[RussKie]

Please rebase

[NikolayXHD]

rebase done

[RussKie]

Works well, nice work.

Few things need further tuning though:

• we should ask for a confirmation when deleting a category, because this is a destructive action and users may lose links to repositories, and those may not necessarily be in "recent repos" list
• we should ask for a confirmation when clearing the "recent repos" list
• whenever we rename or delete categories collapsed state of other groups must be retained
• whenever we rename or delete categories the scroll position must be retained (ideally)

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@96b7ed6). Click here to learn what that means.
The diff coverage is 32.88%.

@@            Coverage Diff            @@
##             master    #5434   +/-   ##
=========================================
  Coverage          ?   35.28%           
=========================================
  Files             ?      606           
  Lines             ?    46222           
  Branches          ?     6304           
=========================================
  Hits              ?    16310           
  Misses            ?    29162           
  Partials          ?      750

[NikolayXHD]

Few things need further tuning though:

we should ask for a confirmation when deleting a category, because this is a destructive action and users may lose links to repositories, and those may not necessarily be in "recent repos" list
we should ask for a confirmation when clearing the "recent repos" list
whenever we rename or delete categories collapsed state of other groups must be retained
whenever we rename or delete categories the scroll position must be retained (ideally)

Done.
Renamed category doesn't keep collapsed state, it allways becomes expanded.
It's not ideal, but acceptable in my opinion, because

• Besides becoming expanded, the renamed category may naturally change its position in the list of groups because of alphabetical sort order. This way it will still mess other groups position in the screen even if collapsed state is preserved. Less frequently and with less amplitude, but it will.
• I am lazy
• I also noticed that keeping renamed category collapsed state was specifically excluded from requested improvements.

[RussKie]

I am lazy
I also noticed that [...] was specifically excluded from requested improvements.

This made me laugh 👍

[RussKie]

I didn't realise this change would be so elaborate with p/invokes.
Well done, works well 👍

[RussKie]

Personally I avoid shadowing existing members, if possible. Though it is not a hard and fast rule... Will it render the designer unusable?

…

On Fri, Sep 21, 2018, 7:50 PM NikolayHD ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In GitUI/UserControls/ExListView.cs <#5434 (comment)> : > } + /// <summary> + /// Position in <see cref="ListView.Groups"/> collection after + /// the technical "Default" group (if present) or 0 + /// </summary> + public int MinGroupInsertionIndex { get; private set; } = 0; I wanted to do it completely incapsulated from the very beginnig. And additionally, I wanted to hide Groups collection by a new member with the same name. It would delegate calls to actual Groups collection and handle the workaround. What stopped me was the fact that it would break using ExListVIew.Groups collection in .designer.cs files, where some groups are added for the sake of visual assistance in design-time. Do you think we can sacrifice these usages? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5434 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEMyXh5mTtsXB2pboff9c2dypQOO9Zlhks5udLZTgaJpZM4WqX7x> .

[NikolayXHD]

Personally I avoid shadowing existing members, if possible. Though it is not a hard and fast rule... Will it render the designer unusable?

Now that you asked, I don't see shadowing as such a great idea anymore, even if designer keeps working. Your suggestion on adding 2 methods InsertGroup and InsertGroups has a clear advantage of not adding any unnesessary complexity and potential for surprising side effects.

[RussKie]

Awesome job! Thank you