Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickPull should behave the same as the default toolbar does. #5897

Conversation

mterwoord
Copy link

@mterwoord mterwoord commented Dec 12, 2018

Changes proposed in this pull request:

  • QuickPull shortcut action should behave the same way as the toolbar button.

What did I do to test the code and ensure quality:

  • Look at surrounding code.

Has been tested on (remove any that don't apply):

  • GIT 2.20
  • Windows 10

@amaiorano
Copy link
Contributor

This is based on the conversation @mterwoord had with me in Gitter. Apparently, in V2, Quick Pull (Ctrl+Shift+P by default) would behave the same as clicking the Pull button on the toolbar. The behaviour of this button changed in V3, and indeed, they no longer did the same thing. I suggested that @mterwoord try out the change that was made here. I think this is fine.

@RussKie
Copy link
Member

RussKie commented Dec 18, 2018

@mterwoord
Copy link
Author

That one works as expected!

@amaiorano
Copy link
Contributor

Also tested and it seems to work as expected.

@RussKie
Copy link
Member

RussKie commented Dec 20, 2018

@mterwoord is this PR addressing a specific issue? If so, could you please update the commit message with "Fixes #XYZ".

@mterwoord
Copy link
Author

I did not add a ticket.

@RussKie RussKie added this to the 3.0.1 milestone Dec 24, 2018
@RussKie RussKie merged commit c9e4865 into gitextensions:master Dec 24, 2018
@RussKie
Copy link
Member

RussKie commented Dec 24, 2018

Thank you

@vbjay vbjay mentioned this pull request Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants