Fix blame control click hold move mouse to the right #6399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
If you "click-hold-move-mouse-to-the-right" to move to the right in the pane to see the rest of the text, there is no way to ever move back. The fix handles horizontal scroll for the committer and blocks the hscroll.
RussKie
force-pushed
the
fix_blame_control_click-hold-move-mouse-to-the-right
branch
from
60a6fd9
to
0a2869f
Compare
|
That fixes the bad behavior. Well done! |
|
Tested, not sure if this was the intended behaviour, but basically "click-hold-mouse button-move right" now has no effect at all any more. This, quite effectively, solves the problem of not being able to move back. As for not being able to see what's "hidden" from view in the left pane: as the screen divider can be moved, that information can be accessed in that manner. So, I'm OK with this change. |
That is the intended behaviour, if a user requires to see more or less information for the committer - they can use the divider. |
RussKie
deleted the
fix_blame_control_click-hold-move-mouse-to-the-right
branch
|
Thank you for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As noted in #6393 (comment) if you "click-hold-move-mouse-to-the-right" to move to the right in
the pane to see the rest of the text, there is no way to ever move back.
The fix handles horizontal scroll for the committer and blocks the hscroll.
Test methodology
✒️ I contribute this code under The Developer Certificate of Origin.