Commit messages menu: Fix (sometimes) broken display #7369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7369 +/- ##
==========================================
- Coverage 48.45% 48.45% -0.01%
==========================================
Files 752 752
Lines 55182 55182
Branches 7175 7175
==========================================
- Hits 26740 26737 -3
- Misses 27014 27038 +24
+ Partials 1428 1407 -21
|
mstv
reviewed
Oct 29, 2019
|
I think this will fix #5115 |
|
I'd like to see some tests as well please |
RussKie
added
the
📭 needs: author feedback
When building the commit message history to display in the dropdown menu, and the commit message is shorter than the maximum length allowed but is a multi line commit message, then the display is broken for all the menus items. => add a check that the commit message is multi line and must be shorten. + increase the length of text in the menu items because 50 char is too short
pmiossec
force-pushed
the
fix_two_lines_menu_items
branch
from
7626678
to
0be8678
Compare
ghost
removed
the
📭 needs: author feedback
|
done. |
mstv
approved these changes
Oct 30, 2019
gerhardol
reviewed
Oct 30, 2019
RussKie
approved these changes
Oct 31, 2019
gerhardol
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5115
Proposed changes
When building the commit message history to display in the dropdown menu,
and the commit message is shorter than the maximum length allowed
but is a multi line commit message,
then the display is broken for all the menus items.
=> add a check that the commit message is multi line and must be shorten.
Screenshots
Before
See the first menu item which is display onto 2 lines and so increase the height of all menu items:
After
Test methodology
Test environment(s)