Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate ToolTips #8756

Merged
merged 2 commits into from Jan 15, 2021
Merged

Conversation

mstv
Copy link
Member

@mstv mstv commented Jan 15, 2021

Fixes #8755

Proposed changes

  • Fixup the check in AddTranslationItemIfNotExist whether the ToolTipText differs from Text
  • Update English.xlf

Test methodology

  • build -loc
  • check English.xlf

Test environment(s)

  • Git Extensions 33.33.33
  • Build f0a3df6
  • Git 2.27.0.windows.1 (recommended: 2.28.0 or later)
  • Microsoft Windows NT 10.0.19042.0
  • .NET Framework 4.8.4300.0
  • DPI 96dpi (no scaling)

✒️ I contribute this code under The Developer Certificate of Origin.

@mstv mstv self-assigned this Jan 15, 2021
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #8756 (f0a3df6) into master (4b33ef3) will decrease coverage by 3.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #8756      +/-   ##
==========================================
- Coverage   56.07%   53.07%   -3.01%     
==========================================
  Files         900      827      -73     
  Lines       65099    60548    -4551     
  Branches    11813    11516     -297     
==========================================
- Hits        36507    32136    -4371     
+ Misses      25682    25636      -46     
+ Partials     2910     2776     -134     
Flag Coverage Δ
production 43.19% <100.00%> (-0.02%) ⬇️
tests 94.37% <ø> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@pmiossec
Copy link
Member

You will be hated by the translators 😁

Copy link
Member

@pmiossec pmiossec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks (and this is the real fix for #3745)

Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mstv mstv merged commit 6513fff into gitextensions:master Jan 15, 2021
@ghost ghost added this to the 4.0 milestone Jan 15, 2021
@mstv mstv deleted the fix/8755_translate_tooltips branch January 15, 2021 22:38
@mstv
Copy link
Member Author

mstv commented Jan 15, 2021

You will be hated by the translators

Wait until I add more mnemonics! Which should really be done.
Though we could strip the regarding & from the translation Source strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate UserControls.Settings.SettingsCheckBox.ToolTipText
4 participants