Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ListView column border in dark theme #8868

Merged
merged 1 commit into from Feb 22, 2021
Merged

fix ListView column border in dark theme #8868

merged 1 commit into from Feb 22, 2021

Conversation

NikolayXHD
Copy link
Member

Fixes #8863

Before

image

After

image

Test environment(s)

  • Windows10
  • 96 dpi

✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned NikolayXHD Feb 21, 2021
@NikolayXHD NikolayXHD requested review from a user, gerhardol and RussKie February 21, 2021 22:19
@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #8868 (221fc39) into master (f9bf40c) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #8868      +/-   ##
==========================================
- Coverage   56.21%   56.20%   -0.01%     
==========================================
  Files         921      921              
  Lines       65579    65591      +12     
  Branches    11991    11991              
==========================================
+ Hits        36863    36864       +1     
- Misses      25725    25736      +11     
  Partials     2991     2991              
Flag Coverage Δ
production 43.38% <0.00%> (-0.01%) ⬇️
tests 94.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Maybe you need to rewrite the commit as the committer is unknown...

No hdpi for me so hardly visible before, works fine.
before/after is slightly different to the description

Good writeup for the theming handling

image

image

@NikolayXHD
Copy link
Member Author

NikolayXHD commented Feb 21, 2021

Maybe you need to rewrite the commit as the committer is unknown...

The commit was done from work pc. It so happens that my wife works the same company, it also so happens, that her initials match mine (n.idalgo - nadia idalgo, nikolay idalgo) so gitlab at work beleives my commits belong to my wife.

I like to keep it that way to confuse my collegues. In this repo however it's not fun at all, so will have to modify the history.

Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend! 🚀

@RussKie
Copy link
Member

RussKie commented Feb 22, 2021

The commit was done from work pc. It so happens that my wife works the same company, it also so happens, that her initials match mine (n.idalgo - nadia idalgo, nikolay idalgo) so gitlab at work beleives my commits belong to my wife.

I like to keep it that way to confuse my collegues. In this repo however it's not fun at all, so will have to modify the history.

🤣
Your better half may now need to provide a sign off too
image

@pmiossec
Copy link
Member

Maybe you need to rewrite the commit as the committer is unknown...

The commit was done from work pc. It so happens that my wife works the same company, it also so happens, that her initials match mine (n.idalgo - nadia idalgo, nikolay idalgo) so gitlab at work beleives my commits belong to my wife.

I like to keep it that way to confuse my collegues. In this repo however it's not fun at all, so will have to modify the history.

Even with the use of 'conditional includes'?

https://blog.jiayu.co/2019/02/conditional-git-configuration/

@gerhardol
Copy link
Member

Even with the use of 'conditional includes'?

Don't encourage the use of conditional includes, not supported by the GE config parsing...

@NikolayXHD NikolayXHD merged commit e77f8c3 into gitextensions:master Feb 22, 2021
@ghost ghost added this to the 3.6 milestone Feb 22, 2021
RussKie pushed a commit that referenced this pull request Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Theming] ListView incorrect column line colour
4 participants