Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theming] ListView incorrect column line colour #8863

Closed
RussKie opened this issue Feb 19, 2021 · 3 comments · Fixed by #8868
Closed

[Theming] ListView incorrect column line colour #8863

RussKie opened this issue Feb 19, 2021 · 3 comments · Fixed by #8868

Comments

@RussKie
Copy link
Member

RussKie commented Feb 19, 2021

Current behaviour

#8849 (comment)

Default Dark
image image

In the default (system) theme the column vertical line is of a faint light blue colour. In the dark theme - the column line's colour is significantly more prominent, and looks the same as the colour as the border.

Steps to reproduce

Checkout 983b0c3 (or the commit from #8849)

@RussKie
Copy link
Member Author

RussKie commented Feb 19, 2021

@NikolayXHD would you be able to look into this? Or may be provide some pointers where to look...
Thanks

@NikolayXHD NikolayXHD self-assigned this Feb 20, 2021
@NikolayXHD NikolayXHD pinned this issue Feb 20, 2021
@NikolayXHD NikolayXHD unpinned this issue Feb 20, 2021
@NikolayXHD
Copy link
Member

NikolayXHD commented Feb 21, 2021

I left a little description of how I handled this, to help in case someone else dares to mess with theming overrides.

https://github.com/gitextensions/gitextensions/wiki/Dark-Theme#further-tweaking-theme-overrides

@ghost ghost added the 🚧 status: in progress Issues which have associated PRs label Feb 21, 2021
@ghost ghost removed the 🚧 status: in progress Issues which have associated PRs label Feb 22, 2021
@RussKie
Copy link
Member Author

RussKie commented Feb 28, 2021

I left a little description of how I handled this, to help in case someone else dares to mess with theming overrides.

gitextensions/gitextensions/wiki/Dark-Theme#further-tweaking-theme-overrides

Champion!

@RussKie RussKie removed this from the 3.5 milestone Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants