RevDiff: Request GitStatus updates at file manipulations

[gerhardol]

#8886 (comment)

Proposed changes

Whenever files are manipulated in RevDiff, request GitStatusMonitor refresh

• If the change was just worktree <-> index, git-status is not triggered at all (until next file system change or every fifth minute)
• If the change is throttled (GitStatusMonitor increase minimum time between updates #8886 increases the minimal time for updates to 30 s), an interactive request is done (delayed 200 ms to possibly bundle changes)

I considered to request the update only at (likely) worktree <-> index changes, but that got more complicated and a faster update is desired after manual changes.
If you stage files one by one, if may cause git-status to run more or less continously (where Git is slow). I do not believe this is a problem, but the request could be done with some delay too.
@mstv?

Note that FormCommit is not affected, it always rescans (not directly with git-status) when a change is done.

Candidate for 3.5 too

Test methodology

Manual

---

✒️ I contribute this code under The Developer Certificate of Origin.

[codecov]

Codecov Report

Merging #8894 (b351ba3) into master (2bf1e3c) will increase coverage by 0.01%.
The diff coverage is 41.46%.

@@            Coverage Diff             @@
##           master    #8894      +/-   ##
==========================================
+ Coverage   56.05%   56.07%   +0.01%     
==========================================
  Files         922      923       +1     
  Lines       65861    65881      +20     
  Branches    12084    12087       +3     
==========================================
+ Hits        36920    36941      +21     
- Misses      25924    25934      +10     
+ Partials     3017     3006      -11     

Flag	Coverage Δ
production	43.30% <41.46%> (+0.02%)	⬆️
tests	94.83% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[mstv]

Thank you! Feels much more responsive.

[RussKie]

👍 with minor suggestions

[gerhardol]

review comments and a similar changes (few) for revfile, browse. (I ignored editing of .gitignore and similar, there are maybe other situations too that will be affected by edit+edit if #8886 is included).

Tested with patched GitStatusMonitor so it runs continuously, works OK. The UI flashes a little but that is separate.

Will squash for merge in about a day (or at feedback).

[mstv]

👍

[gerhardol]

A scenario that is not handled is if you update a submodule in the side panel, without any filesystem changes (for example for a merge commit).
Ignored for now.

[gerhardol]

@msftbot merge in 24 hours

[ghost]

Hello @gerhardol!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

• I won't merge this pull request until after the UTC date Mon, 01 Mar 2021 21:27:02 GMT, which is in 1 day

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".