Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RevDiff: Request GitStatus updates at file manipulations 3.5 #8908

Conversation

gerhardol
Copy link
Member

#8894 for 3.5

For (most) operations related to changes of worktree or index status
in Browse, request immediate git-status update, for the commit count
and artificial commit.
This will bypass the delay between updates. Also changes worktree<->index
would not trigger updates.

Note that operations to submodules in the sidepanel still requires file
system changes.

Should be merged if #8886 is merged in 3.5


✒️ I contribute this code under The Developer Certificate of Origin.

For (most) operations related to changes of worktree or index status
in Browse, request immediate git-status update, for the commit count
and artificial commit.
This will bypass the delay between updates. Also changes worktree<->index
would not trigger updates.

Note that operations to submodules in the sidepanel still requires file
system changes.
@ghost ghost assigned gerhardol Mar 1, 2021
@gerhardol gerhardol marked this pull request as draft March 1, 2021 23:09
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #8908 (f1e7ec3) into release/3.5 (f6d4c2a) will decrease coverage by 0.01%.
The diff coverage is 17.85%.

@@               Coverage Diff               @@
##           release/3.5    #8908      +/-   ##
===============================================
- Coverage        56.17%   56.15%   -0.02%     
===============================================
  Files              923      923              
  Lines            65695    65707      +12     
  Branches         12029    12032       +3     
===============================================
- Hits             36906    36901       -5     
- Misses           25786    25801      +15     
- Partials          3003     3005       +2     
Flag Coverage Δ
production 43.36% <17.85%> (-0.03%) ⬇️
tests 94.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mstv
Copy link
Member

mstv commented Mar 5, 2021

Why have you set this PR to draft?

@gerhardol
Copy link
Member Author

Why have you set this PR to draft?

Because I want some usage in master first and decide if to include the 30s delay as well.

Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@gerhardol gerhardol marked this pull request as ready for review March 7, 2021 11:15
@RussKie RussKie merged commit ebacb7d into gitextensions:release/3.5 Mar 7, 2021
@RussKie RussKie added this to the 3.5 milestone Mar 7, 2021
@gerhardol gerhardol deleted the feature/rev-diff-refresh-status-3.5 branch March 7, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants