Add support for setting console emulator font name

[dasiths]

Add Support For Setting Console Emulator Font Name

This is the 2nd part supplementing the PR to the ConEmu fork gitextensions/conemu-inside#28. The idea is to allow powerline supported fonts.

As shown on the screenshot below, setting the font name to a powerline supported font resulted in this nice rendering.

I could not get the design view for ConsoleStyleSettingsPage to load in Visual Studio 2019 but I hand edited the ConsoleStyleSettingsPage.designer.cs file directly. It build, runs and renders fine but as an improvement I would like to use the standard button based font selection and combine font name + size. I'll do it as a separate PR next.

✒️ I contribute this code under The Developer Certificate of Origin.

[RussKie]

Please make sure the solution builds.

C:\Program Files\dotnet\sdk\5.0.301\Microsoft.Common.CurrentVersion.targets(1717,5): warning NU1702: ProjectReference 'C:\projects\gitextensions\Externals\ICSharpCode.TextEditor\Project\ICSharpCode.TextEditor.csproj' was resolved using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETCoreApp,Version=v5.0'. This project may not be fully compatible with your project. 

[mstv]

Please make sure the solution builds.

It might be caused by the changed other submodules. Perhaps the merge went wrong.

Basically, please do not merge anything into feature branches - rebase instead.

[dasiths]

@RussKie @mstv I've reverted the changes for other submodules. It builds locally for both previously and also now.

[RussKie]

Build FAILED.
C:\projects\gitextensions\GitExtensions\Project.Loc.targets(89,5): error : Please update English translations and re-submit the pull-request. Refer to https://github.com/gitextensions/gitextensions/wiki/Translations [C:\projects\gitextensions\GitExtensions\GitExtensions.csproj]
    0 Warning(s)
    1 Error(s)

[RussKie]

This is radical, but I think this is a good direction. However now the "Console style" page is pretty empty, and perhaps we could consider moving the console font setting to the "Fonts" page, and the console style dropdown to the "Colors" page (under its own group, like "Console theme"?).
What do you think?

[RussKie]

Please revert this piece

[dasiths]

This is radical, but I think this is a good direction. However now the "Console style" page is pretty empty, and perhaps we could consider moving the console font setting to the "Fonts" page, and the console style dropdown to the "Colors" page (under its own group, like "Console theme"?).
What do you think?

I could be awayed either way. I like that the console related stuff is in one sub page but I get your thinking as well.

I was contemplating the fact that the entire ConEmu settings xml can be loaded externally as well and that maybe another feature I could work on next. If we want to try that, then we would need the console sub page to place the xml file path picker for example.

i.e. These are all the settings embedded in that xml file

This isn't a reason to keep the console sub page though. Just something that came to my mind. Let me know how you want to proceed. I can go with you suggested approach if you want.

[RussKie]

I was contemplating the fact that the entire ConEmu settings xml can be loaded externally as well and that maybe another feature I could work on next. If we want to try that, then we would need the console sub page to place the xml file path picker for example.

i.e. These are all the settings embedded in that xml file

Instead of duplicating the ConEmu's settings page, I'd rather see us providing a mechanism to launch the ConEmu configurator. Though personally I don't think it adds any value, you're one of a handful contributors who expressed the desire to tweak it.

[dasiths]

Yeah I wouldn't wanna duplicate it. Rather I was thinking let us point to a xml file from our settings. But like you said, it might be overkill.

So provided we want to continue with the reorg of pages, should I tackle the sub page removal/reorg as a separate PR?

[dasiths]

Build FAILED.
C:\projects\gitextensions\GitExtensions\Project.Loc.targets(89,5): error : Please update English translations and re-submit the pull-request. Refer to https://github.com/gitextensions/gitextensions/wiki/Translations [C:\projects\gitextensions\GitExtensions\GitExtensions.csproj]
    0 Warning(s)
    1 Error(s)

I've added the translations but the build still keep failing :(

[mstv]

I've added the translations but the build still keep failing :(

This is an open issue if the master has translation changes.
So it is a perfect time to rebase on master and squash.

[RussKie]

This is an open issue if the master has translation changes.

I don't believe this has anything to do with #9273

This is what's causing the issue:

[dasiths]

This is an open issue if the master has translation changes.

I don't believe this has anything to do with #9273

This is what's causing the issue:

But that's the change you wanted me to revert right? It fails translation before and after reverting that change.

[RussKie]

Yes. You're introduced trailing spaces, which must be undone for the translation check to pass.

[dasiths]

Yes. You're introduced trailing spaces, which must be undone for the translation check to pass.

Fixed.

[RussKie]

Please provide an updated screenshot

[RussKie]

👍
Please squash

[dasiths]

👍
Please squash

@RussKie done and pushed.

[RussKie]

Thank you