Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair Translation Check #9273

Closed
mstv opened this issue Jun 7, 2021 · 5 comments · Fixed by #9361
Closed

Repair Translation Check #9273

mstv opened this issue Jun 7, 2021 · 5 comments · Fixed by #9361

Comments

@mstv
Copy link
Member

mstv commented Jun 7, 2021

The translation check has regressed again: fails, if the master has newer translations.

STR:

  • PR with translation change
  • concurrent merge with translation change to master
  • build PR
@RussKie
Copy link
Member

RussKie commented Jun 7, 2021 via email

@RussKie

This comment has been minimized.

@RussKie
Copy link
Member

RussKie commented Jul 9, 2021

Got a repro f5c663c

Here's what's happening:

  1. The master has a changed translation, when we perform a soft reset the index it contains xlf files:
    image
  2. Then we build and run the loc check, which detects the changed xlf

In 3.5 branch we would

  1. Reset
  2. Build
  3. Undo reset
  4. Run loc check

@mstv
Copy link
Member Author

mstv commented Jul 9, 2021

I think you should have a look at the code removed (again) from appveyor.yml in 3eea466 or at 8da72f4.
It did/does only work this way.

RussKie added a commit that referenced this issue Jul 11, 2021
@RussKie
Copy link
Member

RussKie commented Jul 11, 2021

@mstv mstv reopened this Jul 11, 2021
@ghost ghost added the 🚧 status: in progress Issues which have associated PRs label Jul 11, 2021
@ghost ghost removed the 🚧 status: in progress Issues which have associated PRs label Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants