Remove BinaryFormatter. Fixes #9150

[GintasS]

Fixes #9150

Proposed changes

• Removed BinaryFormatter code after @pmiossec discovery.

Test methodology

• Current tests were used.

Test environment(s)

GIT 2.21.0.windows.1
Windows 10

---

✒️ I contribute this code under The Developer Certificate of Origin.

[GintasS]

Same tests fail on this one too locally, so I'm going to disregard them.

[pmiossec]

I wonder only on the commit message that I find misleading.

Is something like that better?

"Remove no more used BinaryFormatter for commit template"

[GintasS]

I wonder only on the commit message that I find misleading.

Is something like that better?

"Remove no more used BinaryFormatter for commit template"

Done.

[GintasS]

Should I commit something or how can I rerun a AppVeyor build? Seems to fail for no reason, at least not in regards to this PR.

[pmiossec]

Should I commit something or how can I rerun a AppVeyor build? Seems to fail for no reason, at least not in regards to this PR.

I have re-launched the build of the PR. Failed again.

I don't know if it is linked to #9273 (comment)

If that is the case, could you rebase your work on top of updated master.

Note: to trigger again a build, you could close and then reopen the PR.

[GintasS]

Should I commit something or how can I rerun a AppVeyor build? Seems to fail for no reason, at least not in regards to this PR.

I have re-launched the build of the PR. Failed again.

I don't know if it is linked to #9273 (comment)

If that is the case, could you rebase your work on top of updated master.

Note: to trigger again a build, you could close and then reopen the PR.

Will try. Thanks!

[pmiossec]

It seems to have worked. I think we are good to merge it...