Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup localization verification #9361

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

mstv
Copy link
Member

@mstv mstv commented Jul 11, 2021

Fixes #9273

Proposed changes

  • Restore the working loc verification from 8da72f4
  • Stage all files which have been modified by the build process, a.o. by set_version_to.py

Test methodology

  • CI build

Test environment(s)

  • AppVeyor

✒️ I contribute this code under The Developer Certificate of Origin.

from 8da72f4
and stage all files which have been modified by the build process
@mstv mstv self-assigned this Jul 11, 2021
@RussKie
Copy link
Member

RussKie commented Jul 12, 2021

I've been thinking overnight - we want to build with the hash of the original PR. So perhaps we want to run the loc check first, and only if it passes perform soft reset and build. This way we don't need to do gymnastics of resetting back, etc.
What do you think?

@mstv
Copy link
Member Author

mstv commented Jul 12, 2021

It is not about resetting but about having committed the .xlf files, which have been merged with the master.

Building twice is also gymnastics and will take too much time IMO.

So rather make the script which injects the git info, aware of the CI build and override the hash with the APPVEYOR_PULL_REQUEST_HEAD_COMMIT.

@RussKie RussKie merged commit 18b83b5 into gitextensions:master Jul 13, 2021
@ghost ghost added this to the 3.6 milestone Jul 13, 2021
@RussKie
Copy link
Member

RussKie commented Jul 13, 2021

It is working, though is giving strange output
image

@mstv mstv deleted the fix/9273_loc_verification branch July 13, 2021 20:39
@mstv
Copy link
Member Author

mstv commented Jul 13, 2021

It is working, though is giving strange output

That's why I must reset LASTEXITCODE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repair Translation Check
2 participants