Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Blame Settings page #9801

Merged

Conversation

gerhardol
Copy link
Member

Part of #9796

Proposed changes

Blame settings is currently only in FileHistory. They are a little hidden there, hard to find them.
With master Blame is also in Browse so they need to be accessible.

Another option would have been to add them to the FileViewer context menu.
They would have to be added last in the menu to avoid messing with the FileViewer modes and the logic would have to be added to the blame control too.
Also if that is considered, it is expected to have this in Settings.

Designer opened, tab order tested

Screenshots

Before

Unchanged

image

After

image

Test methodology

Manual

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

Also in FileHistory main menus
@gerhardol gerhardol merged commit d6bfff8 into gitextensions:master Jan 8, 2022
@gerhardol gerhardol deleted the feature/i9796-blame-settings-page branch January 8, 2022 18:10
@ghost ghost added this to the vNext milestone Jan 8, 2022
@mdonatas
Copy link
Contributor

When it was tested was it look at with higher DPI? 200% here
image

@gerhardol
Copy link
Member Author

gerhardol commented Jan 13, 2022

When it was tested was it look at with higher DPI? 200% here

125% looks fine
More resources are needed in the project for everything...

gerhardol added a commit to gerhardol/gitextensions that referenced this pull request Jan 13, 2022
Settings added in gitextensions#9801/d6bfff8cb434c1dea4d642783ca9848ee0bce20a
gerhardol added a commit to gerhardol/gitextensions that referenced this pull request Jan 14, 2022
Settings added in gitextensions#9801/d6bfff8cb434c1dea4d642783ca9848ee0bce20a
gerhardol added a commit to gerhardol/gitextensions that referenced this pull request Jan 14, 2022
Settings added in gitextensions#9801/d6bfff8cb434c1dea4d642783ca9848ee0bce20a
gerhardol added a commit that referenced this pull request Jan 15, 2022
Settings added in #9801/d6bfff8cb434c1dea4d642783ca9848ee0bce20a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants