Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blame settings: Auto size for checkboxes #9817

Merged

Conversation

gerhardol
Copy link
Member

Proposed changes

Add scaling to checkboxes

Settings added in #9801/d6bfff8cb434c1dea4d642783ca9848ee0bce20a

Screenshots

See PR #9801

Test methodology

Manual

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

Settings added in gitextensions#9801/d6bfff8cb434c1dea4d642783ca9848ee0bce20a
@ghost ghost assigned gerhardol Jan 13, 2022
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please dock each control inside the tablelayout too.

Settings added in gitextensions#9801/d6bfff8cb434c1dea4d642783ca9848ee0bce20a
@gerhardol
Copy link
Member Author

Also adjusted sizes and bottom padding
(I adopted to 17 used in General page, 22 is used in some settings too).

@RussKie
Copy link
Member

RussKie commented Jan 14, 2022

I meant docking each individual control inside TLP, so that they all aling uniformly. It also presumably works better with autosizing of controls and host containers.

Settings added in gitextensions#9801/d6bfff8cb434c1dea4d642783ca9848ee0bce20a
@gerhardol
Copy link
Member Author

I meant docking each individual control inside TLP, so that they all aling uniformly. It also presumably works better with autosizing of controls and host containers.

This does not seem to be used by any other settings.
Seem to be OK (tested 200% too).

@gerhardol gerhardol merged commit 523a894 into gitextensions:master Jan 15, 2022
@ghost ghost added this to the vNext milestone Jan 15, 2022
@gerhardol gerhardol deleted the feature/p9801-blame-settings-scaling branch January 15, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants